fix: request password reset (#156)

* ok * test * fix start frontend * fix start frontend
lunary-ai · Mar 29, 2024 · 6f4a6b6 · 6f4a6b6
1 parent 0decb4d
commit 6f4a6b6
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -43,9 +43,8 @@ jobs:
 
       - name: Start frontend
         env:
-          APP_URL: http://localhost:8080
           API_URL: http://localhost:3333
-          NEXT_PUBLIC_API_URL: xyzPLACEHOLDERxyz
+          NEXT_PUBLIC_API_URL: http://localhost:3333
         timeout-minutes: 2
         run: (npm run build:frontend && npm run start:frontend)  & npx wait-on http://localhost:8080/
 

diff --git a/ops b/ops
diff --git a/packages/frontend/components/layout/Navbar.tsx b/packages/frontend/components/layout/Navbar.tsx
@@ -57,7 +57,7 @@ export default function Navbar() {
     setSendingEmail(true)
 
     const ok = await errorHandler(
-      fetch(`${process.env.API_URL}/v1/users/send-verification`, {
+      fetch(`${process.env.NEXT_PUBLIC_API_URL}/v1/users/send-verification`, {
         method: "POST",
         body: JSON.stringify({
           email: user?.email,

diff --git a/packages/frontend/next.config.js b/packages/frontend/next.config.js
@@ -22,7 +22,7 @@ const nextConfig = {
     ],
   },
   async rewrites() {
-    if(!process.env.API_URL) {
+    if(!process.env.NEXT_PUBLIC_API_URL) {
       return []
     }
 
@@ -33,15 +33,15 @@ const nextConfig = {
       },
       {
         source: "/api/v1/report",
-        destination: process.env.API_URL + "/api/report",
+        destination: process.env.NEXT_PUBLIC_API_URL + "/api/report",
       },
       {
         source: "/api/report",
-        destination: process.env.API_URL + "/api/report",
+        destination: process.env.NEXT_PUBLIC_API_URL + "/api/report",
       },
       {
         source: "/api/v1/template",
-        destination: process.env.API_URL + "/api/v1/template",
+        destination: process.env.NEXT_PUBLIC_API_URL + "/api/v1/template",
       },
     ]
   },

diff --git a/packages/frontend/pages/request-password-reset.tsx b/packages/frontend/pages/request-password-reset.tsx
@@ -31,7 +31,7 @@ export default function PasswordReset() {
     setLoading(true)
 
     const res = await errorHandler(
-      fetch(`${process.env.API_URL}/auth/request-password-reset`, {
+      fetch(`${process.env.NEXT_PUBLIC_API_URL}/auth/request-password-reset`, {
         method: "POST",
         headers: {
           "Content-Type": "application/json",

diff --git a/packages/frontend/pages/team.tsx b/packages/frontend/pages/team.tsx
@@ -149,15 +149,15 @@ function SAMLConfig() {
               <Table.Td>Assertion Consumer Service (ACS) URL:</Table.Td>
               <Table.Td>
                 <CopyInput
-                  value={`${process.env.API_URL}/auth/saml/${org?.id}/acs`}
+                  value={`${process.env.NEXT_PUBLIC_API_URL}/auth/saml/${org?.id}/acs`}
                 />
               </Table.Td>
             </Table.Tr>
             <Table.Tr>
               <Table.Td>Single Logout Service (SLO) URL:</Table.Td>
               <Table.Td>
                 <CopyInput
-                  value={`${process.env.API_URL}/auth/saml/${org?.id}/slo`}
+                  value={`${process.env.NEXT_PUBLIC_API_URL}/auth/saml/${org?.id}/slo`}
                 />
               </Table.Td>
             </Table.Tr>
@@ -173,7 +173,7 @@ function SAMLConfig() {
               <Table.Td>Single Logout URL:</Table.Td>
               <Table.Td>
                 <CopyInput
-                  value={`${process.env.API_URL}/auth/saml/${org?.id}/slo`}
+                  value={`${process.env.NEXT_PUBLIC_API_URL}/auth/saml/${org?.id}/slo`}
                 />
               </Table.Td>
             </Table.Tr>

diff --git a/packages/frontend/utils/fetcher/client.ts b/packages/frontend/utils/fetcher/client.ts
@@ -2,8 +2,7 @@ import Router from "next/router"
 import { signOut } from "../auth"
 import { showErrorNotification } from "../errors"
 
-const BASE_URL =
-  (process.env.API_URL as string) || process.env.NEXT_PUBLIC_API_URL
+const BASE_URL = process.env.NEXT_PUBLIC_API_URL as string
 
 export function buildUrl(path: string) {
   if (path.includes("/auth")) {