Skip to content

Commit

Permalink
fix: padding auth page (#684)
Browse files Browse the repository at this point in the history
Signed-off-by: Hugues Chocart <[email protected]>
  • Loading branch information
hughcrt authored Dec 26, 2024
1 parent 9695fc4 commit a509da8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 74 deletions.
71 changes: 0 additions & 71 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,74 +14,3 @@ jobs:
run: |
echo "Tests temporarily disabled"
exit 0
# name: Run tests

# on:
# pull_request:
# types: [opened, synchronize]
# workflow_dispatch:

# jobs:
# run-tests:
# if: ${{ !contains(github.head_ref, 'ci:') && !contains(github.ref, 'ci/') }}
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - name: Cache node modules
# id: cache-npm
# uses: actions/cache@v4
# env:
# cache-name: cache-node-modules
# with:
# path: ~/.npm
# key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ runner.os }}-build-${{ env.cache-name }}-
# ${{ runner.os }}-build-
# ${{ runner.os }}-

# - name: Cache Playwright binaries
# uses: actions/cache@v4
# id: playwright-cache
# with:
# path: ~/.cache/ms-playwright
# key: ${{ runner.os }}-playwright-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ runner.os }}-playwright-

# - name: Install dependencies
# run: npm ci

# - name: Install Playwright
# run: npx playwright install --with-deps chromium

# - name: Start backend
# env:
# DATABASE_URL: ${{ secrets.DATABASE_URL }}
# JWT_SECRET: ${{ secrets.JWT_SECRET }}
# APP_URL: http://0.0.0.0:8080
# API_URL: http://0.0.0.0:3333
# LUNARY_PUBLIC_KEY: 259d2d94-9446-478a-ae04-484de705b522
# OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
# timeout-minutes: 1
# run: npm run start:backend & npx wait-on http://localhost:3333/v1/health

# - name: Start frontend
# env:
# API_URL: http://0.0.0.0:3333
# NEXT_PUBLIC_API_URL: http://0.0.0.0:3333
# timeout-minutes: 3
# run: (npm run dev:frontend) & npx wait-on http://0.0.0.0:8080/

# - name: Run tests
# run: npx playwright test
# env:
# BASE_URL: http://0.0.0.0:8080
# DATABASE_URL: ${{ secrets.DATABASE_URL }}
# - uses: actions/upload-artifact@v4
# if: ${{ !cancelled() }}
# with:
# name: playwright-report
# path: playwright-report/
# retention-days: 30
5 changes: 2 additions & 3 deletions packages/frontend/components/layout/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ export default function Layout({ children }: { children: ReactNode }) {
const isDashboardPage = router.pathname.startsWith("/dashboards/");
const isPromptPage = router.pathname.startsWith("/prompt");
const isTracePage = router.pathname.startsWith("/traces");
const disablePagePadding = isPromptPage || isTracePage || isAuthPage;
const disablePagePadding =
isPromptPage || isTracePage || isAuthPage || isDashboardPage;

useEffect(() => {
if (user) {
Expand Down Expand Up @@ -110,10 +111,8 @@ export default function Layout({ children }: { children: ReactNode }) {
}}
>
{!isAuthPage && !isPublicPage && <Sidebar />}

<Box
p={disablePagePadding ? 0 : 24}
pt={isDashboardPage ? 0 : 24}
pos="relative"
flex={1}
style={{
Expand Down

0 comments on commit a509da8

Please sign in to comment.