fix: test

lunary-ai · Mar 30, 2024 · c5da0f5 · c5da0f5
1 parent d59b021
commit c5da0f5
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 7 deletions.
diff --git a/e2e/api.spec.ts b/e2e/api.spec.ts
@@ -9,15 +9,26 @@ test.describe.configure({ mode: "serial" })
 test("regenerate api keys", async ({ page }) => {
   await page.goto("/settings")
 
+  await page.waitForLoadState("networkidle")
+
   publicKey = await page.getByTestId("private-key").textContent()
 
   const firstPrivateKey = await page.getByTestId("private-key").textContent()
 
-  // expect to not be empty string
-  expect(firstPrivateKey).not.toEqual("")
+  expect(publicKey).toHaveLength(36) // uuid length
+  expect(firstPrivateKey).toHaveLength(36) // uuid length
+
+  await page.waitForTimeout(300) // helps with flakiness in local
 
   await page.getByTestId("regenerate-private-key-button").click()
 
+  const promise = page.waitForResponse((resp) =>
+    resp.url().includes("/regenerate-key"),
+  )
+  await page.getByTestId("confirm-button").click()
+  // wait until button re-contain "Regenerate"
+  await promise
+
   const secondPrivateKey = await page.getByTestId("private-key").textContent()
 
   console.log({ firstPrivateKey, secondPrivateKey })
@@ -30,14 +41,15 @@ test("regenerate api keys", async ({ page }) => {
 test("private api /logs", async ({ page }) => {
   // Test API query
 
-  const res = await fetch(process.env.API_URL + "/api/v1/runs", {
-    method: "POST",
+  const res = await fetch(process.env.API_URL + "/v1/runs", {
+    method: "GET",
     headers: {
       "X-API-Key": privateKey!,
     },
   })
 
   const json = await res.json()
 
-  expect(json).toEqual([])
+  // expect to be an array
+  expect(json).toBeInstanceOf(Array)
 })
diff --git a/e2e/login.spec.ts b/e2e/login.spec.ts
@@ -1,6 +1,6 @@
 import { test, expect } from "@playwright/test"
 
-test("logout and login flow", async ({ page }) => {
+test("logout and back in login", async ({ page }) => {
   await page.goto("/")
 
   // logout
@@ -13,8 +13,12 @@ test("logout and login flow", async ({ page }) => {
   await page.getByPlaceholder("Your email").click()
   await page.getByPlaceholder("Your email").fill("[email protected]")
 
+  const promise = page.waitForResponse((resp) => resp.url().includes("/method"))
+
   await page.getByTestId("continue-button").click()
 
+  await promise
+
   await page.getByPlaceholder("Your password").click()
   await page.getByPlaceholder("Your password").fill("testtest")
 

diff --git a/packages/frontend/pages/settings.tsx b/packages/frontend/pages/settings.tsx
@@ -98,7 +98,10 @@ function Keys() {
                 onClick={() => {
                   modals.openConfirmModal({
                     title: "Please confirm your action",
-                    confirmProps: { color: "red" },
+                    confirmProps: {
+                      color: "red",
+                      "data-testid": "confirm-button",
+                    },
                     children: (
                       <Text size="sm">
                         Are you sure you want to regenerate your private key?