chore: Clippy

.github/workflows/rust.yml

@@ -37,7 +37,7 @@ concurrency:
 
 jobs:
   test:
-    runs-on: gh-32vcpu-128gbram-ubuntu-2204
+    runs-on: warp-ubuntu-2404-x64-32x
     strategy:
       fail-fast: false
     env:
@@ -65,12 +65,10 @@ jobs:
         with:
           components: rustfmt, clippy
       - uses: Swatinem/rust-cache@v2
-      # See '.cargo/config' for list of enabled/disabled clippy lints
+      # See '.cargo/config.toml' for list of enabled/disabled clippy lints
       - name: rustfmt
-        uses: actions-rs/cargo@v1
-        with:
-          command: fmt
-          args: --all --check
+        run: |
+          cargo fmt --all --check
       - name: cargo clippy
         run: cargo xclippy -D warnings
 

crates/bls12381/src/curves/g1.rs

@@ -870,7 +870,7 @@ mod tests {
     fn test_random_mul_by_seed_square() {
         let mut rng = rand::thread_rng();
         let a = G1Projective::random(&mut rng);
-        let x0 = bls12_381::Scalar::from(15132376222941642752);
+        let x0 = Scalar::from(15132376222941642752);
         let c = a * (x0 * x0);
         let a = G1Affine::from(a);
         let c = G1Affine::from(c);

crates/bls12381/src/curves/g2.rs

@@ -985,7 +985,7 @@ mod tests {
     fn test_random_mul_by_seed() {
         let mut rng = rand::thread_rng();
         let a = G2Projective::random(&mut rng);
-        let x0 = bls12_381::Scalar::from(15132376222941642752);
+        let x0 = Scalar::from(15132376222941642752);
         let c = a * x0;
         let c = -c;
         let a = G2Affine::from(a);

crates/chunk/tests/gadget.rs

@@ -41,7 +41,7 @@ impl<F: PrimeField> ChunkStepCircuit<F> for ChunkStep<F> {
 
 // NIVC `StepCircuit`` implementation
 #[derive(Clone, Debug)]
-struct FoldStepWrapper<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
+pub struct FoldStepWrapper<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
     inner: FoldStep<F, C, N>,
 }
 
@@ -77,12 +77,12 @@ impl<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> StepCircuit<F>
 }
 
 // NIVC `NonUniformCircuit` implementation
-struct ChunkCircuit<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
+pub struct ChunkCircuit<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
     inner: InnerCircuit<F, C, N>,
 }
 
 #[derive(Clone, Debug)]
-enum ChunkCircuitSet<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
+pub enum ChunkCircuitSet<F: PrimeField, C: ChunkStepCircuit<F>, const N: usize> {
     IterStep(FoldStepWrapper<F, C, N>),
 }
 

crates/merkle-inclusion/tests/gadget.rs

@@ -348,6 +348,7 @@ impl SimpleMerkleTree {
 /// The path key is a vector of `Boolean` values, where each value indicates a direction at a node:
 /// - `Boolean::constant(false)` for a left turn.
 /// - `Boolean::constant(true)` for a right turn.
+///
 /// The path keys are long as specified by the referred Digest output size bits long, padded with `false` values.
 ///
 /// # Tree Structure

crates/ripemd160/README.md

@@ -1,5 +1,5 @@
 # bellpepper-ripemd160
-A [bellpepper](https://github.com/lurk-lab/bellpepper) gadget for the RIPEMD-160 hash function
+A [bellpepper](https://github.com/argumentcomputer/bellpepper) gadget for the RIPEMD-160 hash function
 
 ## License
 

crates/uint64/src/lib.rs

@@ -306,7 +306,7 @@ impl UInt64 {
 
         // Compute the maximum value of the sum so we allocate enough bits for
         // the result
-        let mut max_value = (operands.len() as u128) * (u128::from(u64::max_value()));
+        let mut max_value = (operands.len() as u128) * (u128::from(u64::MAX));
 
         // Keep track of the resulting value
         let mut result_value = Some(0u128);