Unroll schema imports #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanAkbar
approved these changes
Dec 31, 2024
lib/lutaml/xsd/glob.rb
Outdated
Comment on lines
50
to
51
| separator = "/" unless schema_location&.start_with?("/") || location&.end_with?("/") | ||
| [location, schema_location].join(separator) |
ronaldtse
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
@suleman-uzair can you help address @HassanAkbar 's comment and we can merge this? Please also update the README. Thanks!
suleman-uzair
force-pushed
the
feature/import_schema_flattened
branch
from
2630083 to
0f3b925
Compare
|
Released version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports loading schema recursively from each
importtag using theURLorpathprovided in theschemaLocationattribute.closes lutaml/lutaml-model#181