Fix return value of Clone functions when CloneOptions.NewID is set
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Clone` functions (`Container.Clone` and `VM.Clone`), when called with `CloneOptions.NewID` set, return 0 instead of the `NewID`.
luthermonson
reviewed
Sep 5, 2024
luthermonson
reviewed
Sep 5, 2024
luthermonson
approved these changes
Sep 9, 2024
|
excellent pr @rybnico and thanks for your contribution |
|
@luthermonson Any plans to do a new patch release? I have another PR that needs this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Clonefunctions (Container.CloneandVM.Clone), when called withCloneOptions.NewIDset, return 0 instead of theNewID.I extended the tests. Updated
TestContainerCloneand newTestVirtualMachineClonetests fail without this fix.