-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use latest xlink repo and added Clang support #1094
base: develop
Are you sure you want to change the base?
Conversation
Thanks @onthegrid007 - any particular reason for the switch to ninja? |
CI fails on MacOS: https://github.com/luxonis/depthai-core/actions/runs/10337442673/job/28646392973 Let's either leave the CI builders as is or extend with a "matrix" to build with both GCC and Clang. |
Ninja is required for Clang on windows to overwrite the use of MSVS compiler in Cmake... Thought it would be easier overall if everything just switched over at once. |
Unfortunately unless I rebuild opencv in the ci I have to use clang with a target for mingw and mingw be the library target on windows, Ninja is still required for it not to default to MSVS, and since it's only a single binary for installation I'm not too worried... Question, @moratom should I rebuild opencv cleanly in the ci so clang can work without mingw (see windows latest build for the error I'm mentioning) or is there a way like it kind of mentions to just specify opencv_dir and hope there's no binary discrepancies between the mingw prebuilt opencv binaries and clang compiling with msvs as the target libraries? |
@onthegrid007 we don't necessarily want to switch the CI to clang, rather we should extend it, so we run both with GCC and clang in the CI. You can use the "matrix" for that in github actions. Note that we'll be mainlining the updated XLink in this PR #1098 and keep the this one to expend the CI to clang. |
Is this good enough? |
Update to use latest xlink repo and added Clang support