Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lodepng.c to simplify build process for c #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffboody
Copy link

Would you consider including this change so that the lodepng.cpp file does not need to be renamed for C?

@lvandeve
Copy link
Owner

Hi, it's indeed a bit odd that it has to be like this, but keeping two files up to date is also not guaranteed to be perfect, so I'd prefer to leave it as-is, sorry for the small inconvenience

@jeffboody
Copy link
Author

I think you are under the impression that I simply made a duplicate copy of the cpp file. But I actually just included it from the c file. There is nothing extra to keep up-to-date because the only implementation is in the cpp file.

Can you take another look at the patch?

@lvandeve
Copy link
Owner

Hmm, it's a way indeed... I'm considering it. But it's still odd, just like the current "rename to c" version. So I might as well keep the current odd solution. Not sure yet :)

@miniupnp
Copy link

miniupnp commented Dec 5, 2020

Why not a symbolic link ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants