Feature/foutafhandeling #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
fsamwel
reviewed
Oct 19, 2021
JohanBoer
approved these changes
Oct 20, 2021
strijm
reviewed
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Met de foutafhandeling.feature file heb ik gedocumenteerd welke fouten de API nu retourneert bij verschillende fout situaties. Voor nu is alleen voor geometrie parameters (locatie en bbox) verbeter voorstellen gedaan tbv consistentie en gebruiksvriendelijke foutmeldingen
Side note: behalve de feature file zitten ook een package.json en package-lock.json file in de P.R. Dit komt doordat er van de master branch een branch is getrokken en er wordt gemerged naar de develop-1.4