Change if statements in autoip.c to fix compiler warnings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What warnings did you get? |
|
Unused lines of code if LWIP_DHCP_AUTOIP_COOP is not 0 |
sebhub
reviewed
Nov 22, 2024
src/core/ipv4/autoip.c
Outdated
| if (autoip && (autoip->state != AUTOIP_STATE_OFF) && !LWIP_DHCP_AUTOIP_COOP) { | ||
| LWIP_DEBUGF(AUTOIP_DEBUG | LWIP_DBG_TRACE, | ||
| if (autoip && (autoip->state != AUTOIP_STATE_OFF)) { | ||
| #ifdef LWIP_DHCP_COOP |
There was a problem hiding this comment.
This #ifdef is superfluous here and below. The #if and #endif should start at the begin of the line. There is a typo LWIP_DHCP_COOP -> LWIP_DHCP_AUTOIP_COOP. Don't you get set but not used warnings with this change and the one below?
There was a problem hiding this comment.
Oh, thank you. No, I didn't get any warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got warnings about unused code when tried to build example app with clang-14 so I moved options checks to preprocessor if statements