incus: Improve completion for config keys #1387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: montag451 <[email protected]>
montag451
force-pushed
the
improve-conf-keys-comp
branch
from
34b0056 to
08c7f40
Compare
|
No, it's not. The LXD repository is under a different license, we cannot legally even look at the content of a pull request which is copying code from the LXD repository. |
|
OK but the LXD completion code comes from Incus in the first place as you can see here canonical/lxd@3c0f463. Doesn't it make the code a Apache-2.0 licenced code? I really don't understand how licenses are supposed to work in this context. |
|
The original code may have originated with us, but if they then extended it, that change isn't Apache 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is mainly copy/paste from the LXD repository. Is it OK to do that ?