Fix incorrect volume group naming when vg_name
is not specified
#1653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of clustering, when
vg_name
is not specified, the name of the storage pool that the user wants to create is used as the volume group name. This approach is incorrect if the source is a volume group name, as it leads to a mismatch between the source (volume group name) and the storage pool name, causing issues.To address this, we need to detect such cases. In other scenarios, such as when a physical device is specified as the source, the storage pool name provided by the user should be used as the volume group name.
To solve this issue, a helper method was implemented to determine the source type based on the value of
config["source"]
. This method works as follows:If the source is empty, a loop file, or a physical device, the storage pool name is used as the volume group name.
If the source is a volume group name, then that name is used as the volume group name.
This helper method ensures consistent naming logic and is now used in both the
init()
andCreate()
methods.Fixes: #1650