Make sure the new runtime dir exists before mounting.

This seems to be required under some choices of runtime dir. Also clean up some redundant logging.

Signed-off-by: Sebastien Dabdoub <[email protected]>

src/bindings.c

@@ -762,6 +762,11 @@ static int permute_prepare(void)
 		return -1;
 	}
 
+	if (!mkdir_p(new_runtime, 0755)) {
+		lxcfs_error("Failed to create dir %s\n", new_runtime);
+		return -1;
+	}
+
 	if (mount(runtime_path, new_runtime, NULL, MS_BIND, 0) < 0) {
 		lxcfs_error("Failed to bind-mount %s into new root: %s.\n", runtime_path, strerror(errno));
 		return -1;

src/bindings.h

@@ -107,13 +107,13 @@ struct lxcfs_opts {
 	bool swap_off;
 	bool use_pidfd;
 	bool use_cfs;
-        // As of opts version 2.
-        char runtime_path[PATH_MAX];
 	/*
 	 * Ideally we'd version by size but because of backwards compatability
 	 * and the use of bool instead of explicited __u32 and __u64 we can't.
 	 */
 	__u32 version;
+        // As of opts version 2.
+        char runtime_path[PATH_MAX];
 };
 
 typedef enum lxcfs_opt_t {