Fixed setting of default app in Properties dialog #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLib has a weird problem. On the one hand, `g_app_info_set_as_default_for_type()` writes to `~/.config/mimeapps.list`. On the other hand, the DE-specific list — e.g., `~/.config/lxqt-mimeapps.list` in LXQt — has priority over it and GLib respects that. Therefore, if the latter exists and contains some default apps, `g_app_info_set_as_default_for_type()` could not change them. This patch solves the problem by adding a utility function that sets the default app directly inside the DE-specific list. Also, see lxqt/libqtxdg#219.
tsujan
force-pushed
the
fix_default_app_setting
branch
from
0a5c857
to
07dcf64
Compare
|
@luis-pereira libfm-qt/src/appchooserdialog.cpp Line 241 in 928a85a g_app_info_set_as_last_used_for_type() automatically adds the association; PCMan's comment: "add this app to the mime-type").
Since libfm-qt is the place where we use GLib most actively, there isn't a need to an extra dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLib has a weird problem. On the one hand,
g_app_info_set_as_default_for_type()writes to~/.config/mimeapps.list. On the other hand, the DE-specific list — e.g.,~/.config/lxqt-mimeapps.listin LXQt — has priority over it and GLib respects that. Therefore, if the latter exists and contains some default apps,g_app_info_set_as_default_for_type()could not change them.This patch solves the problem by adding a utility function that sets the default app directly inside the DE-specific list.
Also, see lxqt/libqtxdg#219.