Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startlxqtwayland: Correctly identify Niri and Hyprland #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Conan-Kudo
Copy link

Niri is not a member of wlroots (it uses Smithay) and Hyprland is a completely independent compositor (it no longer uses wlroots).

Niri is not a member of wlroots (it uses Smithay) and Hyprland
is a completely independent compositor (it no longer uses wlroots).
@stefonarch
Copy link
Member

That's true, but atm we need wlroots here to load the correct backend in the panel. If you would test your PR you would find no taskbar in the panel in both compositors.

Of course we could just copy the wlroots backend to smithhay and hyprland, but until there are no other features implemented it them it makes little sense.

@Conan-Kudo
Copy link
Author

It does work though, since your code falls back to wlroots backend when you don't say wlroots in the string.

@Conan-Kudo
Copy link
Author

Oh wait, I see, it looks for wlroots substring for this. Okay, I'll drop this.

@Conan-Kudo Conan-Kudo closed this Nov 3, 2024
@Conan-Kudo
Copy link
Author

Actually, it seems like the logic is supposed to work, and it doesn't do what it says it does, so I made a patch to fix it: lxqt/lxqt-panel#2161

@Conan-Kudo Conan-Kudo reopened this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants