Fix some ICE connectivity issues #1641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Oct 6, 2020
| @@ -112,7 +112,7 @@ int NicerConnection::ice_connected(void *obj, nr_ice_peer_ctx *pctx) { | |||
| } | |||
| conn->updateIceState(IceState::READY); | |||
| conn->nicer_->IceContextFinalize(conn->ctx_, pctx); | |||
|
|
|||
| conn->nicer_->IcePeerContextDumpState(pctx, 0); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been investigating some issues that led to having different ICE states between browser and Erizo in some cases. Some of the issues were solved here, while others need to be fixed in nICEr (I'm also preparing a PR there).
The major issue was that Erizo considered all Host candidates as failed because they were using their private IP network, even if we define a Public IP one. For those cases, we now automatically add the Public IP as the Host candidates' address when it is set in the config file.
As part of this work, I've been experimenting a bit with ICE-LITE. I haven't completed it yet because it is low priority, as Firefox does not seem to support ICE-LITE MCUs. The good news is that I've solved some issues that I found during the process.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.