Fix issues when using ICE Trickle #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Oct 6, 2020
src/ice/ice_candidate_pair.c
Outdated
| @@ -621,6 +621,26 @@ int nr_ice_candidate_pair_insert(nr_ice_cand_pair_head *head,nr_ice_cand_pair *p | |||
| return(0); | |||
| } | |||
|
|
|||
| void nr_ice_candidate_pair_check_reduncancy(nr_ice_cand_pair_head *head,nr_ice_cand_pair *pair) | |||
There was a problem hiding this comment.
consider nr_ice_candidate_pair_check_redundancy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICE Trickle is not fully supported by nICEr in its current state. More specifically, I've been having issues because RFC
draft-ietf-ice-trickle Section 11.4 was not implemented in the library.
I've also fixed a function to dump the state and I refactored a little bit the logs to show more data and simplify ICE investigations that debug sessions.