Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky footer from getbootstrap.com/2.3.2/examples/sticky-footer-navbar.... #18

Merged
merged 2 commits into from
Sep 10, 2014

Conversation

maxired
Copy link
Contributor

@maxired maxired commented Sep 8, 2014

Un premier essai pour corriger #17
Une solution plus propre serait d'intégrer https://github.com/incuna/angular-sticky-footer

@franckverrot
Copy link
Member

cc @fpellet @devcrafting

@devcrafting
Copy link
Contributor

Je regarde ce que ça donne (ne pas merger il y a une coquille dans le css).

@devcrafting
Copy link
Contributor

Ca marche (à part la coquille) et ça me va bien.
@maxired tu peux corriger ligne 19, après #push, il manque une accolade (ou je pousse la correction comme tu préfères ?). Merci.

@devcrafting devcrafting closed this Sep 8, 2014
@devcrafting devcrafting reopened this Sep 8, 2014
@devcrafting
Copy link
Contributor

Question : est-ce qu'on ne garderait pas en permanence le footer en bas de page ?

@maxired
Copy link
Contributor Author

maxired commented Sep 8, 2014

@devcrafting , j'ai rajouté le '{' dans le css.
Désolé, je ne suis pas allé a LyonCSS :p

Perso je ne suis pas pour un pied de page fixe.

devcrafting added a commit that referenced this pull request Sep 10, 2014
sticky footer from getbootstrap.com/2.3.2/examples/sticky-footer-navbar....
@devcrafting devcrafting merged commit 15341e6 into lyontechhub:dev Sep 10, 2014
@maxired maxired deleted the sticky branch September 30, 2014 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants