Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun flaky tests #211

Merged
merged 4 commits into from
Feb 20, 2019
Merged

Rerun flaky tests #211

merged 4 commits into from
Feb 20, 2019

Conversation

pboothe
Copy link
Contributor

@pboothe pboothe commented Feb 19, 2019 •
edited by shelbychen97
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Feb 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1971

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.053%
Totals Coverage Status
Change from base Build 1957: 0.0%
Covered Lines: 808
Relevant Lines: 1523
💛 - Coveralls

@pboothe pboothe requested a review from gfr10598 February 19, 2019 23:19
@pboothe
Copy link
Contributor Author

pboothe commented Feb 19, 2019

Fixes #173

@pboothe pboothe added the Task label Feb 19, 2019
gfr10598
gfr10598 requested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@gfr10598 gfr10598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 2 files at r2.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

travis, line 1 at r2 (raw file):

Subproject commit 3eda04b22d0d0b4ca33620f92c0ff223ebdb1c50

Merge?

@pboothe pboothe merged commit 46b6da6 into master Feb 20, 2019
@pboothe pboothe deleted the fix-flaky-tests branch February 20, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfr10598 gfr10598 gfr10598 requested changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pboothe @coveralls @gfr10598