Add multiple scenarios for BBR-terminated testing #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-soltesz
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)
app/measure/measure.js line 223 at r1 (raw file):
userAcceptedDataPolicy: true, downloadworkerfile: "/libraries/pt-download-worker.min.js", metadata: md[Math.floor(Math.random()*md.length)]
Please just add a comment like: "Randomly choose to run one of the configurations above."
cristinaleonr
commented
Sep 11, 2024
There was a problem hiding this comment.
Reviewable status:
app/measure/measure.js line 223 at r1 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
Please just add a comment like: "Randomly choose to run one of the configurations above."
Done, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following test exit scenarios to the BBR-terminated testing:
The scenarios chosen on each run is randomized.
The preview is here.
This change is