Set the global start time when the first connection is established

[robertodauria]

This makes sure that we are only counting the elapsed time after at least one stream has started.

---

This change is 

[coveralls]

Pull Request Test Coverage Report for Build 6706749025

• 0 of 19 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.8%) to 70.067%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/client/client.go	0	19	0.0%

Totals
Change from base Build 6357457566:	-0.8%
Covered Lines:	838
Relevant Lines:	1196

---

💛 - Coveralls

[stephen-soltesz]

Is it possible to test these changes?

Reviewable status: 0 of 1 approvals obtained (waiting on @robertodauria)

---

pkg/client/client.go line 90 at r1 (raw file):

	recvByteCountersMutex sync.Mutex

	globalStartTime     time.Time

Calling a struct field "global" is a misnomer. Is this just startTime for this client instance?

[robertodauria]

Reviewable status: 0 of 1 approvals obtained (waiting on @stephen-soltesz)

---

pkg/client/client.go line 90 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Calling a struct field "global" is a misnomer. Is this just startTime for this client instance?

It's the common start time that all the streams started by this client share for the purpose of computing the aggregate goodput. sharedStartTime or just startTime?

[stephen-soltesz]

Reviewable status: 0 of 1 approvals obtained (waiting on @robertodauria)

---

pkg/client/client.go line 90 at r1 (raw file):

Previously, robertodauria (Roberto D'Auria) wrote…

It's the common start time that all the streams started by this client share for the purpose of computing the aggregate goodput. sharedStartTime or just startTime?

👍

sharedStartTime works for me.

[robertodauria]

I refactored the code a bit to make testing easier in the future, but did not have time to add tests in this PR. Will add them when I'm back in January, if that works for you.

Reviewable status: 0 of 1 approvals obtained (waiting on @stephen-soltesz)

---

pkg/client/client.go line 90 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

👍

sharedStartTime works for me.

Done.

[stephen-soltesz]

Reviewable status: complete! 1 of 1 approvals obtained