fix(archive): archive final messages sent to client

[stephen-soltesz]

Previously, #30 ensured that before closing the connection a final measurement message was sent to the client. However, that message was not saved in the archival result.

This change ensures that the final measurement is saved to the archival results.

Fixes: #32

---

This change is 

[coveralls]

Pull Request Test Coverage Report for Build 7478717470

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 69.992%

---

Totals
Change from base Build 7453335104:	-0.1%
Covered Lines:	877
Relevant Lines:	1253

---

💛 - Coveralls

[robertodauria]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)

---

pkg/throughput1/protocol.go line 235 at r1 (raw file):

}

func (p *Protocol) sendAndSaveWireMessage(ctx context.Context, m model.Measurement, results chan<- model.WireMeasurement) error {

I find the name a bit confusing:sendAndSave but it sends twice (first over the network, then over a chan).

[stephen-soltesz]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @robertodauria)

---

pkg/throughput1/protocol.go line 235 at r1 (raw file):

Previously, robertodauria (Roberto D'Auria) wrote…

I find the name a bit confusing:sendAndSave but it sends twice (first over the network, then over a chan).

Oh, I think you're right. I was thinking of the ServerMeasurements where the results are stored.. but that's a layer violation - this package has no idea the results are saved in the handler package.

I've renamed to saveAndPublishWireMeasurement throughout. ("WireMessage" was actually a typo for "WireMeasurement" originally).