Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not meant to be merged.
This is an example of how to serve a third protocol from msak-server, in case we ever need it and also as an example for future integrations. Tested with:
go run ./cmd/msak-server -pt.enabled
And the packet-test client at https://github.com/m-lab/packet-test/blob/main/cmd/client/ndt7/ndt7.go (changing the port to 8081).
Notes:
netx
in this repository andnetx
in ndt-server are two differentnetx
s and so that the PT server has theConn
it expects (I suspect this highlights the need to merge the two and perhaps movenetx
to m-lab/go)static.NDT7DownloadURLPath
so it could workThis change is