Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packet-test protocol server #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Aug 15, 2024

Not meant to be merged.

This is an example of how to serve a third protocol from msak-server, in case we ever need it and also as an example for future integrations. Tested with:
go run ./cmd/msak-server -pt.enabled

And the packet-test client at https://github.com/m-lab/packet-test/blob/main/cmd/client/ndt7/ndt7.go (changing the port to 8081).

Notes:

  • I spawn a second HTTP server due to the fact the netx in this repository and netx in ndt-server are two different netxs and so that the PT server has the Conn it expects (I suspect this highlights the need to merge the two and perhaps move netx to m-lab/go)
  • The path in the pt Go client appears to be wrong, I had to change it to the value of static.NDT7DownloadURLPath so it could work

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant