Fix building issues with fast-mda-traceroute #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
@SaiedKazemi noticed me that the ci/dockercloud-stage was still failing (see #152) due to the building of fast-mda-traceroute (FMT), and in particular pycaracal dependency.
Luckily I could reproduce the issue locally this time.
I think the issue could be resolved by simply updating Python packaging management tools (pip, wheel and setuptool) before installing pycaracal and FMT in the Dockerfile :
Unfortunately, this simple change led to a cascade of other changes in pycaracal (dioptra-io/caracal#53, dioptra-io/caracal#54) and FMT(dioptra-io/fast-mda-traceroute#3) to make it work properly (the principal reason is that now Conan is by default in version 2.0, which lead to breaking changes in pycaracal build) .
It works now locally but I also had to upgrade the Ubuntu Docker image from 20.04 to 22.04 to have Python 3.10 by default.
If it's not ok for other reasons, we could also just update the Python version to 3.10 in the 20.04 Ubuntu Docker image.
If it looks good to you, we could test if the Docker CI works with these changes.
Best,
Matthieu.
This change is