Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building issues with fast-mda-traceroute #160

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

matthieugouel
Copy link
Contributor

@matthieugouel matthieugouel commented Mar 7, 2023

Hi,

@SaiedKazemi noticed me that the ci/dockercloud-stage was still failing (see #152) due to the building of fast-mda-traceroute (FMT), and in particular pycaracal dependency.

Luckily I could reproduce the issue locally this time.
I think the issue could be resolved by simply updating Python packaging management tools (pip, wheel and setuptool) before installing pycaracal and FMT in the Dockerfile :

RUN pip3 install --upgrade pip wheel setuptools

Unfortunately, this simple change led to a cascade of other changes in pycaracal (dioptra-io/caracal#53, dioptra-io/caracal#54) and FMT(dioptra-io/fast-mda-traceroute#3) to make it work properly (the principal reason is that now Conan is by default in version 2.0, which lead to breaking changes in pycaracal build) .

It works now locally but I also had to upgrade the Ubuntu Docker image from 20.04 to 22.04 to have Python 3.10 by default.
If it's not ok for other reasons, we could also just update the Python version to 3.10 in the 20.04 Ubuntu Docker image.

If it looks good to you, we could test if the Docker CI works with these changes.

Best,
Matthieu.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 562

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.983%

Totals Coverage Status
Change from base Build 557: 0.0%
Covered Lines: 669
Relevant Lines: 697

💛 - Coveralls

Copy link
Member

@SaiedKazemi SaiedKazemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@SaiedKazemi
Copy link
Member

@matthieugouel Thank you for this PR. The Travis CI build was successful so I will merge it.

@SaiedKazemi SaiedKazemi merged commit 06af2e1 into m-lab:main Mar 8, 2023
@matthieugouel matthieugouel deleted the fix-caracal-build branch March 8, 2023 10:47
@SaiedKazemi
Copy link
Member

@matthieugouel Docker Hub builds are also successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants