fix(clone): Ignore reflect.rtype
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #23
This pull request introduces changes to the
clone.goandclone_test.gofiles to enhance the handling of certain types and add new test cases. The key changes involve the introduction of a map to ignore specific types during cloning operations and the addition of new test functions.Enhancements in type handling:
clone.go: Added a newignoreTypesmap to list types that should not be redacted, such as*reflect.rtype, to prevent panics caused by copying certain types.clone.go: Modified theclonefunction to check against theignoreTypesmap and return the source value if it matches an ignored type.Additions to test coverage:
clone_test.go: Added a new test functionTestCloneFuncto verify that functions are correctly cloned without modification.clone_test.go: Added a new test functionTestUnmarshalTypeErrorto ensure that JSON unmarshalling errors are correctly logged and handled.