Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ERC20Extended): emit Approval event in permit #18

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

PierrickGT
Copy link
Member

Fix regression introduced in the following PR: #14

Issue:

Copy link

Changes to gas cost

Generated at commit: a338e0a0b57bb43419ab3be3276a07340bc780be, compared to commit: 0a0cae40c2c88625cb455fd41bb2a5740f85a7d3

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ERC20ExtendedHandler mint
transferfrom
-892 ✅
-203 ✅
-1.69%
-0.72%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20ExtendedHandler 1,255,247 (0) approve
burn
mint
transfer
transferfrom
31,283 (+40)
22,778 (+1,118)
45,681 (0)
30,047 (0)
27,054 (-1,118)
+0.13%
+5.16%
0.00%
0.00%
-3.97%
31,283 (+40)
22,778 (+140)
51,879 (-892)
30,081 (-72)
27,974 (-203)
+0.13%
+0.62%
-1.69%
-0.24%
-0.72%
31,283 (+40)
22,778 (0)
46,429 (+748)
30,047 (-132)
28,172 (-5)
+0.13%
0.00%
+1.64%
-0.44%
-0.02%
31,283 (+40)
22,778 (0)
79,881 (0)
30,246 (0)
28,304 (+121)
+0.13%
0.00%
0.00%
0.00%
+0.43%
2 (-1)
2 (-6)
6 (+1)
10 (+5)
5 (+1)

Copy link

LCOV of commit 29deaf2 during Forge Coverage #75

Summary coverage rate:
  lines......: 98.5% (133 of 135 lines)
  functions..: 98.1% (52 of 53 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  src/ERC20Extended.sol        |95.5%     22|90.0%    10|    -      0

Copy link
Contributor

@toninorair toninorair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierrickGT PierrickGT merged commit 81e204c into main Feb 26, 2024
2 checks passed
@PierrickGT PierrickGT deleted the fix/WEB3-754-permit-approval-event branch February 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants