Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove transceiver instructions parameter #16

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

0xIryna
Copy link
Collaborator

@0xIryna 0xIryna commented Nov 7, 2024

Proposed Changes:

  • remove transceiverInstructions parameter from sendMTokenIndex, sendRegistrarKey and sendRegistrarListStatus in HubPortal
  • use the default transceiver instructions instead (new bytes(1)), so callers are unable to override the default relaying mechanism.

Copy link

github-actions bot commented Nov 7, 2024

LCOV of commit 5772b6b during Forge Coverage #96

Summary coverage rate:
  lines......: 96.6% (198 of 205 lines)
  functions..: 90.5% (67 of 74 functions)
  branches...: 79.2% (38 of 48 branches)

Files changed coverage rate:
                                 |Lines       |Functions  |Branches    
  Filename                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================
  src/HubPortal.sol              | 100%     43| 100%    11|85.7%      7

Copy link

github-actions bot commented Nov 7, 2024

Changes to gas cost

Generated at commit: 516c04c40c48fb51ad03390309cf2283d2d88f46, compared to commit: 870efba6e1ba95eefc4b7b3ffa5e76b44780b962

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
HubPortal 5,535,383 (-9,032) currentIndex
getMigratesImmutables
getMode
mode
rateLimitDuration
registrar
sendMTokenIndex
sendRegistrarKey
sendRegistrarListStatus
setThreshold
setTransceiver
tokenDecimals
transferOwnership
upgrade
2,078 (-22)
2,504 (-44)
361 (+45)
331 (-22)
327 (-22)
327 (-22)
71,706 (-406)
69,028 (-343)
69,881 (-320)
9,014 (+66)
188,494 (-22)
3,815 (-22)
29,448 (-22)
62,093 (-132)
-1.05%
-1.73%
+14.24%
-6.23%
-6.30%
-6.30%
-0.56%
-0.49%
-0.46%
+0.74%
-0.01%
-0.57%
-0.07%
-0.21%
3,619 (-22)
2,504 (-44)
361 (+45)
331 (-22)
327 (-22)
327 (-22)
71,706 (-406)
69,028 (-343)
69,881 (-320)
9,014 (+66)
188,494 (-22)
3,815 (-22)
29,448 (-22)
63,343 (-132)
-0.60%
-1.73%
+14.24%
-6.23%
-6.30%
-6.30%
-0.56%
-0.49%
-0.46%
+0.74%
-0.01%
-0.57%
-0.07%
-0.21%
2,183 (-22)
2,504 (-44)
361 (+45)
331 (-22)
327 (-22)
327 (-22)
71,706 (-406)
69,028 (-343)
69,881 (-320)
9,014 (+66)
188,494 (-22)
3,815 (-22)
29,448 (-22)
63,343 (-132)
-1.00%
-1.73%
+14.24%
-6.23%
-6.30%
-6.30%
-0.56%
-0.49%
-0.46%
+0.74%
-0.01%
-0.57%
-0.07%
-0.21%
8,034 (-22)
2,504 (-44)
361 (+45)
331 (-22)
327 (-22)
327 (-22)
71,706 (-406)
69,028 (-343)
69,881 (-320)
9,014 (+66)
188,494 (-22)
3,815 (-22)
29,448 (-22)
64,593 (-132)
-0.27%
-1.73%
+14.24%
-6.23%
-6.30%
-6.30%
-0.56%
-0.49%
-0.46%
+0.74%
-0.01%
-0.57%
-0.07%
-0.20%
4 (0)
2 (0)
5 (0)
3 (0)
2 (0)
3 (0)
1 (0)
1 (0)
1 (0)
5 (0)
25 (0)
5 (0)
2 (0)
2 (0)

@0xIryna 0xIryna merged commit fd059a9 into main Nov 7, 2024
4 checks passed
@0xIryna 0xIryna deleted the fix/remove-transceiver-instructions-parameter branch November 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants