feat(script): add dev deploy and config scripts #2

PierrickGT · 2024-10-03T01:10:26Z

No description provided.

github-actions · 2024-10-03T01:11:38Z

LCOV of commit `bfcd720` during Forge Coverage #83

Summary coverage rate:
  lines......: 95.6% (194 of 203 lines)
  functions..: 90.4% (66 of 73 functions)
  branches...: 80.9% (38 of 47 branches)

Files changed coverage rate:
                                 |Lines       |Functions  |Branches    
  Filename                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================
  src/SpokePortal.sol            |90.6%     32|88.9%     9| 100%     10
  src/SpokeVault.sol             | 100%     15| 100%     4| 100%      6
  src/governance/Configurator.sol|87.0%     23|80.0%    10|55.6%      9
  src/governance/Governor.sol    | 100%     22| 100%     9| 100%      7
  src/governance/Migrator.sol    |75.0%      8|60.0%     5| 0.0%      2
  src/libs/RegistrarReader.sol   | 100%      3| 100%     3|    -      0

github-actions · 2024-10-15T23:38:00Z

Changes to gas cost

Generated at commit: 806a1785f4047f2e88fd7694bd3cf68d19ea6f05, compared to commit: 7212f883e61152642646333a2e9279181141a551

🧾 Summary (20% most significant diffs)

Contract	Method	Avg (+/-)	%
HubPortal	initialize setPeer	+8 ❌ -173 ✅	+0.01% -0.32%

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
HubPortal	5,554,374 (0)	initialize setPeer	127,584 (0) 49,762 (-4,454)	0.00% -8.22%	127,592 (+8) 54,043 (-173)	+0.01% -0.32%	127,584 (0) 54,216 (0)	0.00% 0.00%	127,630 (+46) 54,262 (+46)	+0.04% +0.08%	26 (+5) 25 (+4)

0xIryna

Fixing submodules must be done in a separate PR

PierrickGT · 2024-10-21T16:29:53Z

Fixing submodules must be done in a separate PR

Done in this PR: #5

…B3-1200-add-deploy-scripts

0xIryna · 2024-10-21T21:55:51Z

script/helpers/Utils.sol

+
+import { ICreateXLike } from "../deploy/interfaces/ICreateXLike.sol";
+
+contract Utils {


Could be a library

0xIryna · 2024-10-21T22:00:21Z

Makefile

+deploy-local-spoke:
+	FOUNDRY_PROFILE=production forge script script/deploy/dev/DeployDevSpoke.s.sol:DeployDevSpoke --private-key $(DEV_PRIVATE_KEY) --rpc-url localhost --skip test --non-interactive --broadcast -v
+
+deploy-dev-sepolia:


I'm concerned about this approach. It doesn't scale well since adding a new chain requires to duplicate all those commands and it's easy to make a copy-paste mistake.
Is it possible to just pass a chain name and read all the required information from json config?

We can refactor later but we should still keep one command per network.

0xIryna · 2024-10-21T22:05:22Z

script/cast/CastBase.sol

+
+import { Utils } from "../helpers/Utils.sol";
+
+contract CastBase is Script, Utils {


I don't think it's should be called Cast. cast is just a command-line tool, and we're not using it to call the script. Since it sends cross-chain transactions Send is more descriptive name

PierrickGT requested a review from 0xIryna October 3, 2024 01:10

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch 4 times, most recently from 76646e0 to e82ed1e Compare October 10, 2024 19:27

PierrickGT added 8 commits October 10, 2024 15:55

feat(script): add dev deploy scripts

3b53642

feat(script): add dev config scripts

d2c35b5

chore(github): enable fork tests

aaa6bc7

fix(Portals): use relative importh paths

8122a97

chore(lib): update dependencies

0bd3e56

fix(DeployBase): fix SpokePortal address

d421ecb

fix(Makefile): add verify flag to deploy commands

8418cdd

feat(script): add transceivers upgrade script

cc5c79c

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch 2 times, most recently from f8643fd to b4221bc Compare October 10, 2024 22:06

PierrickGT added 2 commits October 10, 2024 17:59

feat(script): add portal uggrade script

faa8982

chore(lib): update dependencies

2d36bb9

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch from b4221bc to 2d36bb9 Compare October 10, 2024 22:59

Base automatically changed from wormhole-ntt-integration to main October 10, 2024 23:28

feat(script): add HubPortal cast commands

f23059e

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch from bcd7b3d to ea158dc Compare October 15, 2024 23:22

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch 2 times, most recently from 8b6dd2c to 55a447f Compare October 18, 2024 21:20

0xIryna requested changes Oct 21, 2024

View reviewed changes

PierrickGT added 2 commits October 21, 2024 14:15

Merge branch 'main' into feat/WEB3-1200-add-deploy-scripts

3b6ea4f

feat(script): add SmartM token deploy script

f8d4238

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch from bb8adbc to f8d4238 Compare October 21, 2024 19:25

chore(git): add build sizes workflow test

e3bf133

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch from a8ce4b3 to e3bf133 Compare October 21, 2024 19:38

PierrickGT requested a review from 0xIryna October 21, 2024 19:47

toninorair self-requested a review October 22, 2024 15:58

PierrickGT added 6 commits October 25, 2024 17:40

Merge branch 'main' into feat/WEB3-1200-add-deploy-scripts

779c8f9

chore(lib): remove wrapped-m-token

4a02907

feat(Deploy): add SpokeVault to deploy script

ade50f2

feat(Governance): add Governor and Configurator contracts (#3)

bbc24d0

fix(SpokeVault): use Migratable from common

346c7f6

chore(lib): update common

74ba0f9

toninorair approved these changes Oct 30, 2024

View reviewed changes

feat(Deploy): add Spoke SmartM Earner Manager

4130092

PierrickGT force-pushed the feat/WEB3-1200-add-deploy-scripts branch from 131d27e to 4130092 Compare October 30, 2024 21:31

PierrickGT added 2 commits October 30, 2024 17:06

Merge branch 'main' of github.com:m0-foundation/m-portal into feat/WE…

3dd3dd7

…B3-1200-add-deploy-scripts

fix(SpokePortal): fix IndexingMath import path

bfcd720

0xIryna approved these changes Oct 30, 2024

View reviewed changes

PierrickGT merged commit aad42f1 into main Oct 30, 2024
4 checks passed

PierrickGT deleted the feat/WEB3-1200-add-deploy-scripts branch October 30, 2024 23:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(script): add dev deploy and config scripts #2

feat(script): add dev deploy and config scripts #2

PierrickGT commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024 •

edited

Loading

0xIryna left a comment

PierrickGT commented Oct 21, 2024

0xIryna Oct 21, 2024

0xIryna Oct 21, 2024

PierrickGT Oct 30, 2024

0xIryna Oct 21, 2024


		import { ICreateXLike } from "../deploy/interfaces/ICreateXLike.sol";

		contract Utils {


		import { Utils } from "../helpers/Utils.sol";

		contract CastBase is Script, Utils {

feat(script): add dev deploy and config scripts #2

feat(script): add dev deploy and config scripts #2

Conversation

PierrickGT commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 • edited Loading

LCOV of commit bfcd720 during Forge Coverage #83

github-actions bot commented Oct 15, 2024 • edited Loading

Changes to gas cost

🧾 Summary (20% most significant diffs)

0xIryna left a comment

Choose a reason for hiding this comment

PierrickGT commented Oct 21, 2024

0xIryna Oct 21, 2024

Choose a reason for hiding this comment

0xIryna Oct 21, 2024

Choose a reason for hiding this comment

PierrickGT Oct 30, 2024

Choose a reason for hiding this comment

0xIryna Oct 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2024 •

edited

Loading

LCOV of commit `bfcd720` during Forge Coverage #83

github-actions bot commented Oct 15, 2024 •

edited

Loading