Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outstanding principal #25

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

toninorair
Copy link
Collaborator

@toninorair toninorair commented Nov 21, 2024

Outstanding principal calculations won't be valid if HubPortal is not earning

Copy link

github-actions bot commented Nov 21, 2024

LCOV of commit 8a54027 during Forge Coverage #128

Summary coverage rate:
  lines......: 84.2% (176 of 209 lines)
  functions..: 74.3% (52 of 70 functions)
  branches...: 75.0% (36 of 48 branches)

Files changed coverage rate:
                                 |Lines       |Functions  |Branches    
  Filename                       |Rate     Num|Rate    Num|Rate     Num
  =====================================================================
  src/HubPortal.sol              | 100%     33| 100%     9| 100%      4
  src/Portal.sol                 | 100%     25|81.8%    11| 100%      5
  src/SpokePortal.sol            | 100%     34| 100%     7| 100%     11

@toninorair toninorair closed this Nov 21, 2024
@toninorair toninorair reopened this Nov 21, 2024
@0xIryna 0xIryna self-requested a review November 21, 2024 15:59
Copy link

github-actions bot commented Nov 21, 2024

Changes to gas cost

Generated at commit: 94f7567ba7f8ff510988e11ed31974aa2a0589bf, compared to commit: aa86b2676d1e606844ecf24c70e7db8b902ac5f7

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
SpokePortal attestationReceived
transfer
-31,223 ✅
-168,583 ✅
-27.16%
-55.20%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
SpokePortal 5,217,265 (-175,084) attestationReceived
currentIndex
mToken
registrar
setPeer
setTransceiver
transfer
54,004 (-5,802)
1,150 (-50)
323 (+22)
371 (+110)
54,172 (-67)
188,471 (-45)
136,834 (-162,383)
-9.70%
-4.17%
+7.31%
+42.15%
-0.12%
-0.02%
-54.27%
83,744 (-31,223)
1,150 (-50)
323 (+22)
371 (+110)
54,172 (-67)
188,471 (-45)
136,834 (-168,583)
-27.16%
-4.17%
+7.31%
+42.15%
-0.12%
-0.02%
-55.20%
78,972 (-60,912)
1,150 (-50)
323 (+22)
371 (+110)
54,172 (-67)
188,471 (-45)
136,834 (-171,683)
-43.54%
-4.17%
+7.31%
+42.15%
-0.12%
-0.02%
-55.65%
114,865 (-25,019)
1,150 (-50)
323 (+22)
371 (+110)
54,172 (-67)
188,471 (-45)
136,834 (-171,683)
-17.89%
-4.17%
+7.31%
+42.15%
-0.12%
-0.02%
-55.65%
17 (+9)
1 (-1)
1 (-30)
1 (-30)
16 (-28)
16 (-15)
1 (-2)

@0xIryna 0xIryna force-pushed the feat/remove-outstanding-principal branch from af64f43 to 8a54027 Compare November 21, 2024 16:30
@0xIryna 0xIryna merged commit 607f03b into main Nov 21, 2024
4 checks passed
@0xIryna 0xIryna deleted the feat/remove-outstanding-principal branch November 21, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants