feat: smart M bridging #29
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
LCOV of commit
|
PierrickGT
reviewed
Nov 27, 2024
Comment on lines
+159
to
+160
| // Pre-compute the expected SpokeSmartMToken proxy address. | ||
| address expectedSmartMTokenProxy_ = ContractHelper.getContractFrom(deployer_, _SPOKE_SMART_M_TOKEN_PROXY_NONCE); |
There was a problem hiding this comment.
Would be best to deploy it before the SpokePortal.
Kind of tricky cause we need the SpokeVault and SpokePortal address but we can pre-compute these.
I think it's best to deploy the contracts that rely on nonces first and then we deploy the ones that rely on Create3.
|
|
||
| /// @inheritdoc IPortal | ||
| function setRemoteSmartMToken(uint16 remoteChainId_, bytes32 smartMToken_) external onlyOwner { | ||
| remoteSmartMToken[remoteChainId_] = smartMToken_; |
There was a problem hiding this comment.
Should revert if trying to set it for the local network/chainId.
0xIryna
force-pushed
the
feat/smart-m-bridging
branch
from
12cab5a to
73d72bb
Compare
0xIryna
force-pushed
the
feat/smart-m-bridging
branch
from
9176d84 to
d04ff4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
transferWrappedMTokenfunction to transfer a generic Wrapped M token by specifying source and destination Wrapped token addresses. Under the hood Wrapped M token is unwrapped to M token on the source, M token is bridged and wrapped back on the destination.transferWrappedMTokenfunction can be used to transfer M token extensions or convert from one wrapper on the source to another on the destination.transferSmartMTokenfunction to transfer Smart M token cross-chain. It's a simplified version oftransferWrappedMTokenfunction that doesn't take source and destination token addresses, as Smart M token address is set in the constructor.setRemoteSmartMTokenfunction to store Smart M Token address on the remote chains._receiveMTokento handle M Token wrapping on the destination. If wrapping fails, M token is transferred to he the recipient.Challenges:
Due to the current Wormhole NTT design it's not possible to utilize NTTManager transfer for transferring Wrapped tokens and as a result some of the functionality is duplicated.
Next Steps and Questions:
transferWrappedMTokenandtransferSmartMTokenat this point.MTokenSentandMTokenReceivedbe modified?