-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Wrapped M bridging #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PierrickGT
reviewed
Jan 17, 2025
toninorair
reviewed
Jan 27, 2025
toninorair
reviewed
Jan 27, 2025
PierrickGT
requested changes
Jan 29, 2025
PierrickGT
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Provide the ability to bridge both official M^0 Wrapped M token and generic M token extensions using M Portal by unwrapping tokens on the source, bridging M and wrapping them back on the destination. The proposed solution allows flexible bridging and wrapping. E.g., from M to Wrapped M, from M Extension to M, etc.
Proposed changes
mapping
to store addresses of $M token on the remote chain. It will be used to determine the destination $M address whenINttManager.transfer
function is called. The mapping can be updated only by the owner.mapping
to store the supported bridging paths between local and remote chains. The mapping can be updated only by the owner.transferMLikeToken
function to transfer a generic M like token by specifying source and destination token addresses. Under the hood, if the source token is Wrapped M token, it's unwrapped to M token, M token is bridged and wrapped back on the destination if needed._receiveMToken
to handle M Token wrapping on the destination. If wrapping fails, M token is transferred to the recipient.Challenges
Due to the current Wormhole NTT design it's not possible to utilize NTTManager functions for transferring Wrapped tokens. We decided to fork Wormhole's
native-transfer-tokens
repo and make_transferEntryPoint
functions virtual to reduce code duplication and prevent Yul stack too deep issues.Next Steps: