Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove getPenalties getter #180

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Apr 19, 2024
@deluca-mike deluca-mike self-assigned this Apr 19, 2024
@deluca-mike deluca-mike marked this pull request as ready for review April 19, 2024 18:32
Copy link

github-actions bot commented Apr 19, 2024

Changes to gas cost

Generated at commit: 49b055c2fac29f0536f7d23e7304cd695518328d, compared to commit: f758c9776abbe1365fcd1401389e84e609c0f241

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
MinterGatewayHarness internalCollateralOf
isActiveMinter
penalizedUntilOf
rateModel
updateCollateralInterval
-22 ✅
-22 ✅
-22 ✅
+89 ❌
-582 ✅
-3.04%
-3.22%
-3.10%
+7.40%
-29.83%
MinterGateway inactiveOwedMOf -22 ✅ -2.49%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
MinterGatewayHarness 4,091,088 (-66,467) activeOwedMOf
burnM
cancelMint
collateralOf
collateralPenaltyDeadlineOf
deactivateMinter
inactiveOwedMOf
internalCollateralOf
isActiveMinter
mintM
mintNonce
penalizedUntilOf
proposeMint
proposeRetrieval
rateModel
setCollateralOf
setIsActive
setIsDeactivated
setLastSignatureTimestamp
setMintProposalOf
setPrincipalOfTotalActiveOwedM
setRawOwedMOf
setTotalInactiveOwedM
totalActiveOwedM
ttgRegistrar
ttgVault
updateCollateral
updateCollateralInterval
updateCollateralValidatorThreshold
2,024 (0)
25,362 (0)
27,922 (0)
2,298 (+372)
2,248 (-22)
24,143 (-22)
910 (-22)
701 (-22)
661 (-22)
23,836 (-22)
2,415 (-22)
687 (-22)
24,315 (0)
23,766 (0)
1,291 (+89)
27,129 (0)
22,429 (0)
27,250 (+88)
27,724 (+89)
67,337 (0)
24,028 (-22)
24,385 (0)
43,668 (0)
1,529 (-22)
284 (-22)
329 (-22)
26,114 (0)
1,364 (-22)
1,203 (-22)
0.00%
0.00%
0.00%
+19.31%
-0.97%
-0.09%
-2.36%
-3.04%
-3.22%
-0.09%
-0.90%
-3.10%
0.00%
0.00%
+7.40%
0.00%
0.00%
+0.32%
+0.32%
0.00%
-0.09%
0.00%
0.00%
-1.42%
-7.19%
-6.27%
0.00%
-1.59%
-1.80%
2,396 (+2)
68,011 (+7)
32,127 (+2)
2,298 (+2)
2,265 (-22)
69,757 (-22)
910 (-22)
701 (-22)
661 (-22)
123,856 (+8)
2,415 (-22)
687 (-22)
111,358 (+531)
95,292 (+1)
1,291 (+89)
27,269 (+1)
28,432 (-341)
44,283 (+88)
33,424 (+89)
67,531 (+10)
43,393 (-54)
43,819 (-29)
43,733 (-2)
1,862 (-22)
284 (-22)
329 (-22)
133,385 (-464)
1,369 (-582)
1,203 (-22)
+0.08%
+0.01%
+0.01%
+0.09%
-0.96%
-0.03%
-2.36%
-3.04%
-3.22%
+0.01%
-0.90%
-3.10%
+0.48%
+0.00%
+7.40%
+0.00%
-1.19%
+0.20%
+0.27%
+0.01%
-0.12%
-0.07%
-0.00%
-1.17%
-7.19%
-6.27%
-0.35%
-29.83%
-1.80%
2,024 (0)
62,166 (+12)
32,169 (+9)
2,298 (0)
2,248 (-22)
94,283 (-22)
910 (-22)
701 (-22)
661 (-22)
125,371 (-22)
2,415 (-22)
687 (-22)
113,256 (0)
96,383 (0)
1,291 (+89)
27,285 (0)
22,429 (0)
44,350 (+88)
27,724 (+89)
67,553 (0)
44,024 (-10)
44,333 (0)
43,692 (0)
1,529 (-22)
284 (-22)
329 (-22)
126,419 (0)
1,364 (-22)
1,203 (-22)
0.00%
+0.02%
+0.03%
0.00%
-0.97%
-0.02%
-2.36%
-3.04%
-3.22%
-0.02%
-0.90%
-3.10%
0.00%
0.00%
+7.40%
0.00%
0.00%
+0.20%
+0.32%
0.00%
-0.02%
0.00%
0.00%
-1.42%
-7.19%
-6.27%
0.00%
-1.59%
-1.80%
6,024 (0)
88,482 (0)
32,188 (0)
2,301 (0)
6,748 (-22)
104,101 (-22)
910 (-22)
701 (-22)
661 (-22)
190,464 (-66)
2,415 (-22)
687 (-22)
113,604 (0)
113,630 (0)
1,291 (+89)
27,477 (0)
44,341 (0)
44,350 (+88)
44,824 (+89)
67,709 (0)
44,096 (-22)
44,453 (0)
43,824 (0)
3,529 (-22)
284 (-22)
329 (-22)
334,122 (-32)
1,377 (-4,509)
1,203 (-22)
0.00%
0.00%
0.00%
0.00%
-0.32%
-0.02%
-2.36%
-3.04%
-3.22%
-0.03%
-0.90%
-3.10%
0.00%
0.00%
+7.40%
0.00%
0.00%
+0.20%
+0.20%
0.00%
-0.05%
0.00%
0.00%
-0.62%
-7.19%
-6.27%
-0.01%
-76.61%
-1.80%
2,802 (-13)
1,226 (-10)
261 (0)
262 (-2)
264 (-1)
5 (0)
516 (0)
1 (0)
3 (0)
526 (-1)
2 (0)
774 (0)
261 (-2)
777 (0)
1 (0)
1,814 (-6)
365 (-8)
258 (0)
3 (0)
780 (0)
1,808 (0)
2,065 (-5)
259 (0)
6 (0)
2 (0)
1 (0)
3,109 (-5)
5 (-3)
1 (0)
MinterGateway 0 (0) burnM
deactivateMinter
inactiveOwedMOf
mintM
proposeMint
totalActiveOwedM
ttgRegistrar
updateCollateral
updateIndex
84,831 (-22)
124,695 (-44)
717 (-22)
143,807 (-44)
96,159 (0)
1,549 (-22)
328 (-22)
113,109 (-22)
69,208 (-22)
-0.03%
-0.04%
-2.98%
-0.03%
0.00%
-1.40%
-6.29%
-0.02%
-0.03%
122,644 (-26)
160,277 (-24)
861 (-22)
165,729 (-106)
104,772 (-1)
1,549 (-22)
328 (-22)
118,726 (-23)
87,352 (-16)
-0.02%
-0.01%
-2.49%
-0.06%
-0.00%
-1.40%
-6.29%
-0.02%
-0.02%
123,196 (-44)
159,975 (-44)
933 (-22)
165,717 (-66)
113,259 (0)
1,549 (-22)
328 (-22)
118,599 (-22)
92,661 (-22)
-0.04%
-0.03%
-2.30%
-0.04%
0.00%
-1.40%
-6.29%
-0.02%
-0.02%
149,996 (-22)
167,491 (-44)
933 (-22)
204,393 (-66)
113,319 (0)
1,549 (-22)
328 (-22)
179,031 (-22)
109,771 (-32)
-0.01%
-0.03%
-2.30%
-0.03%
0.00%
-1.40%
-6.29%
-0.01%
-0.03%
5 (0)
261 (0)
3 (0)
1,049 (0)
1,050 (0)
4,209 (0)
16 (0)
810 (0)
1,557 (0)

Copy link

github-actions bot commented Apr 19, 2024

LCOV of commit 2061cde during Forge Coverage #555

Summary coverage rate:
  lines......: 98.5% (401 of 407 lines)
  functions..: 95.5% (127 of 133 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  src/MinterGateway.sol              | 100%    244|98.5%    65|    -      0

@deluca-mike deluca-mike force-pushed the feat/fee-events branch 2 times, most recently from d5c3d56 to f758c97 Compare April 19, 2024 19:04
@deluca-mike deluca-mike force-pushed the feat/split-fee-getters branch from 0259810 to 15bb34b Compare April 19, 2024 19:08
src/MinterGateway.sol Outdated Show resolved Hide resolved
src/MinterGateway.sol Outdated Show resolved Hide resolved
src/MinterGateway.sol Outdated Show resolved Hide resolved
src/MinterGateway.sol Outdated Show resolved Hide resolved
src/MinterGateway.sol Outdated Show resolved Hide resolved
@toninorair toninorair self-requested a review April 22, 2024 13:58
toninorair
toninorair previously approved these changes Apr 22, 2024
@toninorair toninorair self-requested a review April 22, 2024 16:19
@toninorair toninorair dismissed their stale review April 22, 2024 16:19

change was not added yet

@deluca-mike deluca-mike changed the title feat: getPenalties getter feat: Remove getPenalties getter Apr 22, 2024
@deluca-mike deluca-mike force-pushed the feat/split-fee-getters branch from 01a3e2c to 2061cde Compare April 22, 2024 18:06
@toninorair toninorair merged commit 4340354 into feat/fee-events Apr 23, 2024
5 checks passed
@toninorair toninorair deleted the feat/split-fee-getters branch April 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants