Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MToken): handle mint reverts in Portal #189

Closed
wants to merge 3 commits into from

Conversation

PierrickGT
Copy link
Member

@PierrickGT PierrickGT force-pushed the fix/WEB3-1137-handle-mint-revert-in-portal branch from 8067bd4 to 7742062 Compare August 19, 2024 23:05
Copy link

github-actions bot commented Aug 19, 2024

LCOV of commit 09ddadf during Forge Coverage #585

Summary coverage rate:
  lines......: 96.4% (107 of 111 lines)
  functions..: 92.9% (39 of 42 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  src/MToken.sol                     |97.7%     87|96.2%    26|    -      0

Copy link
Collaborator

@deluca-mike deluca-mike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with this PR is still that:

  • adds more diff than necessary from main to spoke
  • removes checks in an immutable contract in favour of checks in a mutable contract (Portal)
  • creates some coupling between SpokeMToken and a certain upgradeable version of Portal

IMO, we should keep these checks and just also check on the send side.

@PierrickGT
Copy link
Member Author

Closed for the following reasons: #189 (review)

@PierrickGT PierrickGT closed this Aug 20, 2024
@PierrickGT PierrickGT deleted the fix/WEB3-1137-handle-mint-revert-in-portal branch August 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants