Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tests and some relevant cleanup #19

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Jun 27, 2024
@deluca-mike deluca-mike self-assigned this Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Changes to gas cost

Generated at commit: d41f418ce10addb4cecce702ba6368dde9a53973, compared to commit: 0d8273640e783dff8e402a0f2df4de0f1eb3849f

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
MockM setCurrentIndex +2,486 ❌ +7.71%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
MockM 214,604 (0) currentIndex
setCurrentIndex
404 (0)
26,553 (-12)
0.00%
-0.05%
2,100 (+1,316)
34,747 (+2,486)
+167.86%
+7.71%
2,404 (+2,000)
26,565 (0)
+495.05%
0.00%
2,404 (0)
43,653 (0)
0.00%
0.00%
336 (+273)
71 (+65)
MockRegistrar 203,503 (0) setListContains 22,565 (0) 0.00% 39,249 (+250) +0.64% 44,477 (0) 0.00% 44,477 (0) 0.00% 8 (+4)

Copy link

github-actions bot commented Jun 27, 2024

LCOV of commit 02e3e44 during Forge Coverage #90

Summary coverage rate:
  lines......: 95.1% (135 of 142 lines)
  functions..: 93.6% (44 of 47 functions)
  branches...: no data found

Files changed coverage rate:
                           |Lines       |Functions  |Branches    
  Filename                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================
  src/WrappedMToken.sol    |98.3%    118|97.1%    35|    -      0

src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@toninorair toninorair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with clean-ups and introduction of unchecked blocks

src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/WrappedMToken.sol Outdated Show resolved Hide resolved
src/interfaces/IWrappedMToken.sol Outdated Show resolved Hide resolved
src/interfaces/IWrappedMToken.sol Outdated Show resolved Hide resolved
src/interfaces/IWrappedMToken.sol Show resolved Hide resolved
@toninorair toninorair requested a review from PierrickGT July 2, 2024 16:12
* Add renames
* refactor: Auto `_setBalanceInfo`

---------

Co-authored-by: Michael De Luca <[email protected]>
@deluca-mike deluca-mike merged commit a5b81bb into main Jul 2, 2024
2 checks passed
@deluca-mike deluca-mike deleted the feat/test-cleanup branch July 2, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants