Fix a bug where all tracks were hidden (Resolves firefox-devtools#1611)

m1rp · Jul 30, 2019 · 6e62e50 · 6e62e50
1 parent 361f18b
commit 6e62e50
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/src/profile-logic/tracks.js b/src/profile-logic/tracks.js
@@ -483,13 +483,13 @@ export function getVisibleThreads(
     globalTrackIndex < globalTracks.length;
     globalTrackIndex++
   ) {
+    if (hiddenGlobalTracks.has(globalTrackIndex)) {
+      continue;
+    }
     const globalTrack = globalTracks[globalTrackIndex];
     if (globalTrack.type === 'process') {
       const { mainThreadIndex, pid } = globalTrack;
-      if (
-        mainThreadIndex !== null &&
-        !hiddenGlobalTracks.has(globalTrackIndex)
-      ) {
+      if (mainThreadIndex !== null) {
         visibleThreads.push(mainThreadIndex);
       }
       const tracks = ensureExists(

diff --git a/src/test/store/receive-profile.test.js b/src/test/store/receive-profile.test.js
@@ -223,6 +223,27 @@ describe('actions/receive-profile', function() {
       ]);
     });
 
+    it('will not hide the only global track', function() {
+      const store = blankStore();
+      const { profile } = getProfileFromTextSamples(
+        `A[cat:Idle]  A[cat:Idle]  A[cat:Idle]  A[cat:Idle]  A[cat:Idle]`,
+        `work work work work work`
+      );
+      const [threadA, threadB] = profile.threads;
+      threadA.name = 'GeckoMain';
+      threadA.processType = 'tab';
+      threadA.pid = 111;
+      threadB.name = 'Other';
+      threadB.processType = 'default';
+      threadB.pid = 111;
+
+      store.dispatch(viewProfile(profile));
+      expect(getHumanReadableTracks(store.getState())).toEqual([
+        'show [thread GeckoMain tab] SELECTED',
+        '  - show [thread Other]',
+      ]);
+    });
+
     it('will hide idle content threads with no RefreshDriverTick markers', function() {
       const store = blankStore();
       const { profile } = getProfileFromTextSamples(