Add comments for getProfile -> getProfileOrNull change

m1rp · Jul 19, 2019 · c1fca76 · c1fca76
1 parent 1214c5b
commit c1fca76
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/actions/receive-profile.js b/src/actions/receive-profile.js
@@ -1048,6 +1048,8 @@ export function getProfilesFromRawUrl(
         );
     }
 
+    // Profile may be null only for the `from-addon` dataSource since we do
+    // not `await` for retrieveProfileFromAddon function.
     return {
       profile: getProfileOrNull(getState()),
       shouldSetupInitialUrlState,

diff --git a/src/components/app/UrlManager.js b/src/components/app/UrlManager.js
@@ -102,6 +102,8 @@ class UrlManager extends React.PureComponent<Props> {
       } = await getProfilesFromRawUrl(window.location);
 
       // Manually coerce these into the proper type due to the FlowFixMe above.
+      // Profile may be null only for the `from-addon` dataSource since we do
+      // not `await` for retrieveProfileFromAddon function.
       const profile: Profile | null = results.profile;
       const shouldSetupInitialUrlState: boolean =
         results.shouldSetupInitialUrlState;