Post-review2 commit: Add a simple test to check a good behavior in th…

…e sidebar for categories in a diffing track

src/test/unit/profile-data.test.js

@@ -36,6 +36,7 @@ import { ensureExists } from '../../utils/flow';
 import getCallNodeProfile from '../fixtures/profiles/call-nodes';
 import {
   getProfileFromTextSamples,
+  getMergedProfileFromTextSamples,
   getJsTracerTable,
 } from '../fixtures/profiles/processed-profile';
 import { funcHasRecursiveCall } from '../../profile-logic/transforms';
@@ -1176,6 +1177,70 @@ describe('getTimingsForPath for an inverted tree', function() {
   });
 });
 
+describe('getTimingsForPath for a diffing track', function() {
+  function setup() {
+    const { profile, funcNamesDictPerThread } = getMergedProfileFromTextSamples(
+      `
+      A              A  A
+      B              B  C
+      D[cat:Layout]  E  F
+    `,
+      `
+      A                  A  A
+      B                  B  B
+      G[cat:JavaScript]  I  E
+    `
+    );
+    const defaultCategory = profile.meta.categories.findIndex(
+      c => c.name === 'Other'
+    );
+    const thread = profile.threads[2];
+
+    const callNodeInfo = getCallNodeInfo(
+      thread.stackTable,
+      thread.frameTable,
+      thread.funcTable,
+      defaultCategory
+    );
+    const curriedGetTimingsForPath = path =>
+      getTimingsForPath(
+        path,
+        callNodeInfo,
+        profile.meta.interval,
+        false /* inverted tree */,
+        thread,
+        profile.meta.categories
+      );
+
+    return {
+      getTimingsForPath: curriedGetTimingsForPath,
+      funcNamesDictPerThread,
+    };
+  }
+
+  it('computes the right breakdowns', () => {
+    const {
+      getTimingsForPath,
+      funcNamesDictPerThread: [{ A }],
+    } = setup();
+    const timings = getTimingsForPath([A]);
+    expect(timings.forPath).toEqual({
+      selfTime: {
+        breakdownByCategory: null,
+        breakdownByImplementation: null,
+        value: 0,
+      },
+      totalTime: {
+        breakdownByCategory: withSingleSubcategory([0, 0, -1, 1, 0, 0, 0, 0]), // Idle, Other, Layout, JavaScript, etc.
+        breakdownByImplementation: {
+          native: 0,
+        },
+        value: 0,
+      },
+    });
+  });
+});
+
 describe('getSamplesSelectedStates', function() {
   const {
     profile,