Updates and refactoring of ltsview #1691
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvinktue
force-pushed
the
ltsview-update
branch
from
95c3409
to
e1f8731
Compare
rvinktue
force-pushed
the
ltsview-update
branch
from
e1f8731
to
49b9c9e
Compare
Removed a useless dependency on GLOB. In case get_filename_component fails however, GLOB_RECURSE is used to attempt a fix. Before it could happen that SOURCE_DIR = source/, and a file is added named a.cpp, but it resides in folder source/subfolder1/a.cpp and it would not be found by get_filename_component, and subsequently GLOB would also miss it. Other solutions: - Adding separate source directories in CMakeLists input like with include directories - Explicitly stating the relative path from the source directory in cmakelists.txt (not tested)
Two cases of GLOB_RECURSE still exist. # TODO: added in those places
*) Many connections between UI and rendering are not yet connected back up and quality of life such as camera starting in a natural position is missing. Currently being rendered using additive blending because it makes debugging slightly easier. Controls should work as expected from arcballcamera except for translation (ctrl + left mouse + drag) which is counterintuitive. Right mouse to rotate and scroll to zoom, middle press and drag to zoom slowly.
NB: Requires full rebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added window that can be opened through view->show graphics info.
Added colour setting for backlink colouring. NB: Long interpolation button does not do anything yet.