Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

post json #31

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

post json #31

wants to merge 7 commits into from

Conversation

iracic
Copy link

@iracic iracic commented May 1, 2014

Parsing POST JSON parameters.
Used scala distribution json parser (deprecated, adds dependency on parser combinators)

@chrisdinn
Copy link
Contributor

Hey, looks like this build is failing on scala 2.10.4. Do you want to take a look?

https://travis-ci.org/mDialog/smoke/builds/24195195

@iracic
Copy link
Author

iracic commented May 1, 2014

Hi,

Due to 2.11 modularization, parser combinator needs to be declared as
dependency.
In 2.10 no need for that, like in
iracic@8fe5c7e

Thank you and regards,
Igor

2014-05-01 19:23 GMT+02:00 Chris Dinn [email protected]:

Hey, looks like this build is failing on scala 2.10.4. Do you want to take
a look?

https://travis-ci.org/mDialog/smoke/builds/24195195


Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-41932543
.

@chrisdinn
Copy link
Contributor

I can't merge this; it'll break the build. It'll have to wait until one of us has the time to make it pass. I think it's a little too early to abandon 2.10 in Travis CI.

If this change absolutely has to have a different implementation on 2.10 and 2.11 I'll wait to merge it until we're ready to drop 2.10. However, I'm very open to alternative solutions if you've got one.

@iracic
Copy link
Author

iracic commented May 2, 2014

Hi Chris,

Alternative could be some 3rd party JSON library.
This way, no change 2.10 vs 2.11.

Thank you and regards,
Igor

2014-05-02 17:21 GMT+02:00 Chris Dinn [email protected]:

I can't merge this; it'll break the build. It'll have to wait until one of
us has the time to make it pass. I think it's a little too early to abandon
2.10 in Travis CI.

If this change absolutely has to have a different implementation on 2.10
and 2.11 I'll wait to merge it until we're ready to drop 2.10. However, I'm
very open to alternative solutions if you've got one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/31#issuecomment-42043232
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants