-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change systemd definition to log to file rather than syslog #21
base: master
Are you sure you want to change the base?
Conversation
I think the changes are correct but I don't yet have a test environment to prove it. |
Merge with latest ma1uta/ma1sd
Thanks for PR, but I don't think that it's a great idea. May be some one want write logs to the syslog. Also you don't need to specify the |
I would disagee. Syslog for the the system not one service on the system. Spamming syslog with messages from every service masks issues that affect the system as a whole. Synapse uses it's own logfile. IMO let the users decide it's not my system or yours so each will have their own requirements. Add a logfile option which can be one of STDOUT or file or STDERR or pipe, etc. |
It's a good idea to let the user decide where to write the log. Default however should be syslog. |
Ok, I see you. I can offer the next solution: current behavior remains without changes but I'll add the configuration option to configure logger, it may be STDOUT, file or remote networt port. Additionally admins can configure the logger to be asynchonous for example. |
Merge from latest ma1sd
…wilio-8.25.0 Bump twilio from 8.24.0 to 8.25.0
As per issue #20