Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change systemd definition to log to file rather than syslog #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

the-moog
Copy link

As per issue #20

@the-moog
Copy link
Author

I think the changes are correct but I don't yet have a test environment to prove it.

Merge with latest ma1uta/ma1sd
@ma1uta
Copy link
Owner

ma1uta commented Feb 6, 2020

Thanks for PR, but I don't think that it's a great idea. May be some one want write logs to the syslog. Also you don't need to specify the -v option because starting from 2.3.0 version you can configure log level in the configuration.

@the-moog
Copy link
Author

the-moog commented Feb 7, 2020

I would disagee. Syslog for the the system not one service on the system. Spamming syslog with messages from every service masks issues that affect the system as a whole. Synapse uses it's own logfile. IMO let the users decide it's not my system or yours so each will have their own requirements. Add a logfile option which can be one of STDOUT or file or STDERR or pipe, etc.

@bpcurse
Copy link

bpcurse commented Feb 8, 2020

It's a good idea to let the user decide where to write the log. Default however should be syslog.

@ma1uta
Copy link
Owner

ma1uta commented Feb 9, 2020

Ok, I see you. I can offer the next solution: current behavior remains without changes but I'll add the configuration option to configure logger, it may be STDOUT, file or remote networt port. Additionally admins can configure the logger to be asynchonous for example.

Merge from latest ma1sd
Craeckie referenced this pull request in Craeckie/ma1sd Apr 8, 2022
…wilio-8.25.0

Bump twilio from 8.24.0 to 8.25.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants