Update automated parameter scan functionality #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnomotani
force-pushed
the
makie_post_processing-update
branch
from
7b87b59 to
ddd6998
Compare
johnomotani
force-pushed
the
parameter-scan-update
branch
from
a7404aa to
92c1840
Compare
johnomotani
force-pushed
the
makie_post_processing-update
branch
from
ddd6998 to
adf3563
Compare
johnomotani
force-pushed
the
parameter-scan-update
branch
from
92c1840 to
9785c06
Compare
johnomotani
force-pushed
the
makie_post_processing-update
branch
from
aeaec3d to
e495284
Compare
johnomotani
force-pushed
the
parameter-scan-update
branch
from
9785c06 to
d2e8491
Compare
`run_type` was originally used as a setting to turn timer output on/off, etc. However, having a const global variable means that moment_kinetics has to be re-(pre-)compiled if the value is changed, which is inconvenient. Refactor so that timing info can be printed if a TimerOutput object is passed to run_moment_kinetics(), so `run_type` is not needed for this. Parameter scans will be re-implemented without using `run_type`.
If any directory on the path specified for a run directory does not exist, then create it - use `mkpath()` instead of `mkdir()`.
The parameter scan functionality (previously provided by `scan_input.jl` and `driver.jl`) had become out of date and no longer worked. This commit replaces the functionality with `parameter_scans.jl` and `run_parameter_scan.jl`. The functionality is essentially the same, except that inputs can now be read from a TOML file, and all runs in a scan are gathered into a subdirectory.
HDF5 seems to have a buffer overrun if file names are too long. Truncate the scanned variable names to 3 characters to make this less likely to happen. Since the parameter scan saves its runs under a unique subdirectory (named after the scan input file), there is no chance of accidentally conflicting with the name of a run from a different scan.
The TimerOutput objects are not actually used, they are leftovers which were required at one point to call run_moment_kinetics().
johnomotani
force-pushed
the
parameter-scan-update
branch
from
d2e8491 to
9b8bde1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter scan functionality (previously provided by
scan_input.jlanddriver.jl) had become out of date and no longer worked. This PR replaces the functionality withparameter_scans.jlandrun_parameter_scan.jl. The functionality is essentially the same, except that inputs can now be read from a TOML file, and all runs in a scan are gathered into a subdirectory.