Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'constant ionization source' #240

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

johnomotani
Copy link
Collaborator

This functionality has been replaced with the more flexible 'external sources' feature, so can now be removed.

Also removes the 'Harrison-Thompson' debug check as this now includes no features that are not in the 'recycling fraction' check.

This functionality has been replaced with the more flexible 'external
sources' feature, so can now be removed.

Also removes the 'Harrison-Thompson' debug check as this now includes no
features that are not in the 'recycling fraction' check.
@mrhardman
Copy link
Collaborator

Could you please document the options required to reproduce the constant ionization source (if you haven't already done so), and then post a link here to where I can find it?

Thank you! (This will remove another set of options : ) ).

@johnomotani
Copy link
Collaborator Author

The external source options are documented in the documentation
https://mabarnes.github.io/moment_kinetics/dev/external_sources_notes/

The harrisonthompson.jl test has settings to reproduce the old 'constant ionization source' with 'external sources':

ionization_frequency = 0.688

test_input_finite_difference = Dict(
                                    ...
                                    "ion_source" => Dict("active" => true,
                                                         "source_strength" => ionization_frequency,
                                                         "source_T" => 0.25,
                                                         "z_profile" => "constant",
                                                         "r_profile" => "constant"),
                                   )

@johnomotani johnomotani merged commit 6240b5f into master Aug 9, 2024
16 of 17 checks passed
@johnomotani johnomotani deleted the remove-constant-ionization-source branch August 9, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants