Multiple source functionality #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple source profiles
…from NamedTuple to structs
…compatible with source struct vectors
…ource for each species as a vector of structs, rather than a NamedTuple for each. This means each amplitude array for the moments structs has one extra dimension, one for each source, so that each source can be applied to each species pdf in turn.
…ment and species as an r, z, n array instead of just r, z.
…y, flow and pressure for each species
…ion for ions when n_neutrals = 0, and fix some more small errors introduced during restructuring of source system
…each species has its information written out to the HDF5 file. Need to update this when possible, so that each source_amplitude can be written out for each source instead.
This change makes it simple to add an extra dimension for which there is not a `coordinate` struct, replacing the special-purpose arguments for n_ion_species, n_neutral_species and diagnostic_var_size.
…nto multiple_sources
…llow create_dynamic_variable() to take in not just coords but NamedTuples to help define dimensions of an array)
`counter` is not the same as `length(ion_sources)` when one or more ion source sections are found. It is simpler to directly iterate over `ion_sources`.
johnomotani
force-pushed
the
multiple_sources
branch
from
12add6d to
e8f2926
Compare
|
Thanks @LucasMontoya4! Eventually we should add a test case that uses multiple sources, but that can wait until you've had time to work with them a bit and pick a favourite 🙂 I'll make an issue to remind us. |
|
Thanks @johnomotani! I'm sorry about those typos - I hope they weren't too pesky to find... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now add multiple sources to the input files, where sources are numbered, so
All input files for tests and example input files have been updated, and plots can now be made for each source individually.