Remove mpi4py setup in parallel CI jobs #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't think it should cause a problem, but is unneeded now that we use OpenMPI from the Julia package manager for the CI jobs, and maybe there is some conflict that is causing intermittent failures in the parallel tests.
|
This change seems to significantly speed up the debug checks (which do run in parallel) and parallel tests. I don't understand why, as apart from not installing OpenMPI on the system (which doesn't take that long) this PR should not change anything - we should be using OpenMPI from the Julia package manager before and after. I guess maybe either installing OpenMPI on the system, or something else the mpi4py setup did, caused some sort of conflict. Or maybe this was just a fluke and we got a super fast server for the tests when they ran for this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't think it should cause a problem, but is unneeded now that we use OpenMPI from the Julia package manager for the CI jobs, and maybe there is some conflict that is causing intermittent failures in the parallel tests.