-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final transfer version #306
Merged
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
e6676ef
Update naming of update_qpar for ions to be update_ion_qpar, in line …
LucasMontoya4 53a673c
Add ion_physics flag to determine drift_kinetic, gyrokinetic or bragi…
LucasMontoya4 6f6df74
Update gyrokinetic flag uses throughout the repo, so that instead of …
LucasMontoya4 e92dc5c
Some of the Braginskii functionality (unfinished)
LucasMontoya4 f92f20f
Merge branch 'master' into ion_flags
LucasMontoya4 a0e2b20
Merge branch 'ion_flags' into ion_braginskii_fluid
LucasMontoya4 1dbf661
Make initialisation for braginskii ion heat flux be calculated from u…
LucasMontoya4 77a30c1
Merge branch 'master' into ion_braginskii_fluid
LucasMontoya4 3b9bc66
Add braginskii heat flux formula by adding an ion dT_dz component in …
LucasMontoya4 1d8b559
add loop to allow n_neutral_species = 0 and CFL plots to still be mad…
LucasMontoya4 bb64609
Merge branch 'master' into ion_braginskii_fluid
LucasMontoya4 77cce1a
Move order of krook_collisions.jl inclusion to allow velocity_moments…
LucasMontoya4 18cd33e
Add plotting for collisionality (comparing gradient scale lengths to …
LucasMontoya4 9a1e30a
Add comparison plots functionality for collisionality_plots, and add …
LucasMontoya4 0e28693
Add comments to boundary condition of braginskii heat flux, and add d…
LucasMontoya4 5ef19bd
Fix bug during restarts to allow for multiple sources while external_…
LucasMontoya4 4213c52
Make collisionality_plots plot the last timestep value (which was ori…
LucasMontoya4 6fc4c76
Merge branch 'master' into ion_braginskii_fluid
LucasMontoya4 14e510d
Merge branch 'master' into ion_braginskii_fluid
johnomotani 701ab84
Add option of overlaying what the Braginskii heat flux would be for t…
LucasMontoya4 0e6d395
Add option for super Gaussian with decay of 4th power instead of seco…
LucasMontoya4 b2b001d
Merge branch 'master' into ion_braginskii_fluid
LucasMontoya4 9d92ca2
Fix typo when energy source used
LucasMontoya4 fab3f8a
Don't plot braginskii overlay if the original simulation itself was a…
LucasMontoya4 8e5ecd9
Add string to braginskii_overlay system to tell you its an overlay, w…
LucasMontoya4 78bf27e
Merge branch 'ion_braginskii_fluid' of github.com:mabarnes/moment_kin…
LucasMontoya4 8309e99
Fix PI_controller file io for option
LucasMontoya4 0062ca8
Edit PI_controller for density_midpoint_control option to begin the s…
LucasMontoya4 1394626
remove printing function that was used for debugging
LucasMontoya4 22f91bd
Change naming from Braginskii_ions to coll_krook_ions, and change ins…
LucasMontoya4 0462f32
Don't evolve shape function if heat flux closure comes from coll_kroo…
LucasMontoya4 7348809
Allow collisionality_plots to animate comparison runs with different …
LucasMontoya4 dc627cf
add neutral controller_integral file_io.jl bug fix (ion version was f…
LucasMontoya4 44ee25a
skip chodura condition check in coll_krook fluid ion case, so that ng…
LucasMontoya4 1b1cac1
Merge branch 'master' into remove_redundant_shapefn_evolution
LucasMontoya4 bc7401d
change gamma back to 2, and change the boundary condition for heat fl…
LucasMontoya4 8155690
Create new module for collision_frequency calculations, so that krook…
LucasMontoya4 66cbcc1
Change gamma_i to 2.5, from Stangeby (25.2)
LucasMontoya4 eb01872
Add temperature_midpoint_control source option. This will change the …
LucasMontoya4 b8d8b6b
Merge branch 'master' into remove_redundant_shapefn_evolution
LucasMontoya4 499b9ec
Change gamma_i boundary condition for coll_krook heat flux closure de…
LucasMontoya4 06dcf5d
Correction to heat flux itself, should be 1D instead of 3D calculation
LucasMontoya4 63321ad
Include all input files that I made for transfer, and the files that …
LucasMontoya4 b65ac35
Add tests for multi source functionality and PI controllers
LucasMontoya4 c91c51e
small changes
LucasMontoya4 f870002
Merge remote-tracking branch 'origin/master' into final_transfer_version
LucasMontoya4 124a715
Merge branch 'master' of github.com:mabarnes/moment_kinetics into fin…
LucasMontoya4 a227169
Merge branch 'master' into final_transfer_version
LucasMontoya4 1dd6046
Merge remote-tracking branch 'origin/master' into final_transfer_version
LucasMontoya4 96032af
move transfer input files from examples to publication inputs folder
LucasMontoya4 b3c5f7f
Add a couple of example multi source files with a collisional closure…
LucasMontoya4 eabb5e9
deleted transfer input files as they were moved
LucasMontoya4 e3035b3
Add docs page for collision_frequencies.jl
LucasMontoya4 bed3de4
remove example files so they are not run by remote server checks
LucasMontoya4 611c284
Change input file for multi source tests to only include 2 tests, whi…
LucasMontoya4 41a17b1
Comment out julia-actions/cache in documentation CI job
johnomotani 1553fa6
Fix MPI in setup_external_sources!() when `ignore_MPI = true`
johnomotani af475cc
Apply suggestions from code review
johnomotani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
89 changes: 0 additions & 89 deletions
89
examples/multi-sources/krook_closure_temp_PI_density_PI_source.toml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to keep a revisioned copy of these files you could just make a new directory to store them in. It looks like only examples/* is checked for *.toml files in the workflow run. https://github.com/mabarnes/moment_kinetics/blob/master/.github/workflows/examples.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that's true, but I'm dumping them all in the publication_inputs folder anyway, so we can keep the examples folder clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW this is not true. The
walkdir("examples/")function recursively runs over all the entries of all the subdirectories ofexamples/as well as the directory itself. So @LucasMontoya4's solution is the only possible one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! I think this is what I meant, but I see I was being imprecise. However, I have noticed that things might not work as described in the past. See commit 998c725. There I noticed that the
fokker_planckexamples with source terms were clearly not being checked as the source terms functions that they would have used were broken for those inputs.