modules/domComplexity/scope.js: query for iframes just once

macbre · May 24, 2024 · c2578e3 · c2578e3
1 parent 793dba5
commit c2578e3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/modules/domComplexity/scope.js b/modules/domComplexity/scope.js
@@ -92,13 +92,17 @@
     })();
 
     // count <iframe> tags
-    document.querySelectorAll("iframe").forEach(function (iframe) {
-      phantomas.incrMetric("iframesCount"); // @desc number of iframe nodes
+    const iframes = document.querySelectorAll("iframe");
+    phantomas.setMetric("iframesCount", iframes.length); // @desc number of iframe nodes
+
+    for (const iframe of iframes) {
+      phantomas.log(`iframe: ${iframe.src}`);
+
       phantomas.addOffender("iframesCount", {
         element: phantomas.getDOMPath(iframe),
         url: iframe.src,
       });
-    });
+    }
 
     phantomas.spyEnabled(true);
   });