fix: continue with error log when commits between versions cannot be found #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleguijt
force-pushed
the
feature/silent-fail-with-commit-checks
branch
from
73917b8 to
46aa468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of hotfix releases we switch to a different
branchname but current versions defined in our component definitions are from the previous branch (mainfor example).When performing
mach-composer updateit correctly retrieves a new version from Mach Cloud but fails fetching commits between old and new (because old does not exist on the new branch name).This change will make sure this error is logged, but the process itself is not aborted and we can continue updating components.