-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acumos sklearn pipeline example #10
base: main
Are you sure you want to change the base?
Add acumos sklearn pipeline example #10
Conversation
Signed-off-by: tomcli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tommy. This looks good. Just a few little nit picks:
- consistent use of single or double quotes for string literals (I usually prefer double quotes instead of single quotes)
sample.py
could be more aptly named, maybeacumos.py
?- should our copyrights read
Copyright 2021 IBM
orCopyright 2021 IBM Corporation
? We need to add it to Dockerfile. The copyright notice insample.py
looks conflicting?
model = Model(classify=classify_iris) | ||
|
||
session = AcumosSession() | ||
session.dump(model, 'my-iris', '.') # creates ./my-iris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this line in comment then add "# creates ./my-iris for web onboarding"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the following lines
session = AcumosSession(push_api="push onboarding URL of your own Acumos instance ") # push onboarding URL is available on your onboarding model page of your Acumos instance
opts=Options(create_microservice=True)
session.push(model,'name of your model',options=opts)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PhilippeDo, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PhilippeDo, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: tomcli [email protected]