Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acumos sklearn pipeline example #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented May 20, 2021

Signed-off-by: tomcli [email protected]

@Tomcli Tomcli requested a review from ckadner May 20, 2021 18:17
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tommy. This looks good. Just a few little nit picks:

  • consistent use of single or double quotes for string literals (I usually prefer double quotes instead of single quotes)
  • sample.py could be more aptly named, maybe acumos.py?
  • should our copyrights read Copyright 2021 IBM or Copyright 2021 IBM Corporation? We need to add it to Dockerfile. The copyright notice in sample.py looks conflicting?

model = Model(classify=classify_iris)

session = AcumosSession()
session.dump(model, 'my-iris', '.') # creates ./my-iris

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this line in comment then add "# creates ./my-iris for web onboarding"

Copy link

@PhilippeDo PhilippeDo May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following lines

session = AcumosSession(push_api="push onboarding URL of your own Acumos instance ") # push onboarding URL is available on your onboarding model page of your Acumos instance
opts=Options(create_microservice=True)
session.push(model,'name of your model',options=opts)

PhilippeDo
PhilippeDo previously approved these changes Jun 17, 2021
@mlx-bot
Copy link
Collaborator

mlx-bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PhilippeDo, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlx-bot-app
Copy link

mlx-bot-app bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PhilippeDo, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants