Add onError parameter to perform helper #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting to reporting function for reporting to error handlers, etc. Also allows setting to null to swallow all errors
maxfierke
force-pushed
the
mf-throw_on_error_perform_helper
branch
from
f8e908a to
e8f634b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting to reporting function for reporting to error handlers, etc. Also allows setting to
nullto swallow all errors. This is useful when using the(perform)helper with tasks that are always having their error states handled in the UI. In these cases, errors being raised either may be surfaced in the UI and the render errors will be extraneous or there's a desire to log directly to an error reporting service.Fixes #435