Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(book): added link to Rust's reference #411

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

CommanderStorm
Copy link
Contributor

No description provided.

@@ -4,7 +4,7 @@ The previous parser owned its data by allocating strings. This can require quite
some memory space, and using borrowed string slices can help use saving space, while
also maybe increasing performances.

If you are familiar with Rust's concept of litefime,
If you are familiar with Rust's concept of lifetimes,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure if this should link to a docs site, but this seems like a sane choice

Suggested change
If you are familiar with Rust's concept of lifetimes,
If you are familiar with [Rust's concept of lifetimes](https://doc.rust-lang.org/rust-by-example/scope/lifetime.html),

@jeertmans jeertmans added the book Related to the book label Aug 7, 2024
@jeertmans jeertmans changed the title chore:fixed tiny typo in the docs chore(book): added link to Rust's reference Aug 7, 2024
@jeertmans
Copy link
Collaborator

Thank you, @CommanderStorm, looks good to me :-)

@jeertmans jeertmans merged commit 0cf2708 into maciejhirsz:master Aug 7, 2024
2 checks passed
@CommanderStorm CommanderStorm deleted the patch-1 branch August 31, 2024 15:21
akrantz01 referenced this pull request in akrantz01/antsi Sep 19, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [logos](https://logos.maciej.codes/)
([source](https://redirect.github.com/maciejhirsz/logos)) | dependencies
| patch | `0.14.1` -> `0.14.2` |

---

### Release Notes

<details>
<summary>maciejhirsz/logos (logos)</summary>

###
[`v0.14.2`](https://redirect.github.com/maciejhirsz/logos/releases/tag/v0.14.2):
- Optional `forbid_unsafe` feature, fuzzing, book, and more!

[Compare
Source](https://redirect.github.com/maciejhirsz/logos/compare/v0.14.1...v0.14.2)

#### What's Changed

- chore(book): added link to Rust's reference by
[@&#8203;CommanderStorm](https://redirect.github.com/CommanderStorm) in
[https://github.com/maciejhirsz/logos/pull/411](https://redirect.github.com/maciejhirsz/logos/pull/411)
- feat: impl Source for T: Deref in no_std by
[@&#8203;yjhmelody](https://redirect.github.com/yjhmelody) in
[https://github.com/maciejhirsz/logos/pull/406](https://redirect.github.com/maciejhirsz/logos/pull/406)
- fix(codegen/regex): allow vec growth on parse by
[@&#8203;LeoDog896](https://redirect.github.com/LeoDog896) in
[https://github.com/maciejhirsz/logos/pull/405](https://redirect.github.com/maciejhirsz/logos/pull/405)
- test: basic fuzzing by
[@&#8203;LeoDog896](https://redirect.github.com/LeoDog896) in
[https://github.com/maciejhirsz/logos/pull/407](https://redirect.github.com/maciejhirsz/logos/pull/407)
- feat(lib): add `forbid_unsafe` feature to disable unsafe code by
[@&#8203;davidkern](https://redirect.github.com/davidkern) in
[https://github.com/maciejhirsz/logos/pull/413](https://redirect.github.com/maciejhirsz/logos/pull/413)
- chore(version): release v0.14.2 by
[@&#8203;jeertmans](https://redirect.github.com/jeertmans) in
[https://github.com/maciejhirsz/logos/pull/422](https://redirect.github.com/maciejhirsz/logos/pull/422)

#### New Contributors

- [@&#8203;CommanderStorm](https://redirect.github.com/CommanderStorm)
made their first contribution in
[https://github.com/maciejhirsz/logos/pull/411](https://redirect.github.com/maciejhirsz/logos/pull/411)
- [@&#8203;yjhmelody](https://redirect.github.com/yjhmelody) made their
first contribution in
[https://github.com/maciejhirsz/logos/pull/406](https://redirect.github.com/maciejhirsz/logos/pull/406)
- [@&#8203;davidkern](https://redirect.github.com/davidkern) made their
first contribution in
[https://github.com/maciejhirsz/logos/pull/413](https://redirect.github.com/maciejhirsz/logos/pull/413)

**Full Changelog**:
maciejhirsz/logos@v0.14.1...v0.14.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/akrantz01/antsi).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
book Related to the book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants